Use arrays for event expectations - #2721
Merged
Merged
Conversation
### What Update the test's event assertions to use the SDK's current event-testing APIs (XDR comparison via `to_xdr`, `filter_by_contract`), and point the example link at the current version. ### Why The old tuple-vec comparison no longer type-checks against the current SDK, so the example as shown would fail to compile.
|
Preview is available here: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates event assertions to use fixed-size arrays supported by ContractEvents, avoiding unnecessary vector allocations.
Changes:
- Replaces four
std::vec!expectations with arrays. - Requires companion
soroban-examples#411to land first.
Recommendation: NEEDS-CHANGES — coordinate merging the companion PR first.
ElliotFriend
approved these changes
Aug 4, 2026
ElliotFriend
left a comment
ElliotFriend
left a comment
Contributor
There was a problem hiding this comment.
nice! thanks for fixing that up!
should we wait for the soroban-examples PR to merge before this one? or is it worth having the fix in the docs sooner?
Member
Author
The soroban-examples pr is merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use fixed-size arrays for single expected events in the events documentation.
Why
ContractEventssupports direct array comparison, so allocatingstd::vec!is unnecessary.Note
Companion example update: stellar/soroban-examples#411
Origin: #2687 (comment)