Use arrays for event expectations - #411
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates event test expectations to use arrays instead of std::vec!, matching preferred API usage.
Changes:
- Replaces two single-element vector expectations with arrays.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
enabled auto-merge (squash)
August 4, 2026 04:40
dmkozh
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use arrays for expected events in the events example tests.
Why
The expected values do not require
std::vec!, matching the preferred API usage.Note
Companion documentation update: stellar/stellar-docs#2721
Origin: stellar/stellar-docs#2687 (comment)