New damage groups for structures#44642
Open
iaada wants to merge 15 commits into
Open
Conversation
# Conflicts: # Resources/Prototypes/Damage/modifier_sets.yml
3 tasks
themias
added
P3: Standard
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
New damage groups for the structure rebalance.
Why / Balance
Our current modifier sets are really extreme and make a lot of entities way stronger than they should be. The new ones also take a different paradigm, focusing on flat reductions rather than percentage reductions (percentage increases are still there). I touch on it more in space-wizards/docs#660 .
Technical details
DamageModifierSets have been split up into separate folders for readability. The old modifiers were placed in their own file and ""deprecated"" to be removed in a later PR, though some of them probably will stay as they're used on items.DamageContainerBoxwas also removed. It was previously used only for cardboard boxes and definitely way too specific to be useful.Test plan
Tested in spreadsheets, not much to test in-game yet.
Requirements
Breaking changes
DamageContainerBoxhas been removed. It was previously used only for cardboard boxes. While not a 1 to 1 replacement,Inorganicshould do in most cases as a replacement.