Remove secure windoors and rebalance windoors#44645
Conversation
# Conflicts: # Resources/Prototypes/Damage/modifier_sets.yml
|
Me when I try to test a PR without reading that it requires other PRs first :clueless: In terms of the rebalance, how are we looking at destructions times for conventional weapons compared to before? I don't mind the secure windoor removal, but my concern would be that it'd help enable break-ins into certain secure areas; mappers take the strength of windoors in mind when mapping and add alternative entry paths via windows (or more likely block them using other structures), so if windoors are made easy to break then that might impact the safety of those areas. Otherwise, I can see this PR being a good change. |
|
I am unable to completely skim the PR at the current moment, does this PR account for the securewindoors that don't have regular windoor equivalents when it comes to the locked access it has? |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Yes, all of those prototypes were accounted for and fixed.
Doors in general will be far less durable, and windoors will be the weakest of the bunch. In fact in general I would say structures are easier to break than before. Windows are still weaker, but generally doors are meant to be the intended entry point of a room as detailed in space-wizards/docs#660. |
About the PR
Removal of secure windoors and associated prototypes. Approved by Emisse.
Also updates the remaining windoors to the planned rebalance values.
Requires:
#44641
#44642
#44644
Why / Balance
Going through the rebalance I saw that secure windoors don't really have a purpose. Windoors themselves are the weakest door and only barely stronger than a reinforced window, which they're usually placed next to. Even if we were to keep them they would still be weaker than an airlock, and often mappers will place two windoors on one tile, effectively being as strong as a secure windoor would be.
Overall I feel the theme of a sliding glass door doesn't inspire thoughts of strength and the secure windoor doesn't have a niche.
Technical details
A lot of migration but also a lot of changes everywhere. The construction graph was updated so that regular windoors can have a steel plate welded on the wire panel with tags added to accomplish it.
A lot of shifting of the windoor prototypes to account for
[AlwaysPushInheritance]on Destructible, pretty much only so that they can drop different glass shards.Test plan
Smash 'em, weld in a wire panel, load a map and check the migration.
Requirements
Breaking changes
Secure windoors and all associated prototypes have been removed and migrated.
Changelog
🆑 aada
MAPS