Skip to content

Bump minimatch to 11.0.4 for Dependabot alert 402 - #2355

Merged
subodhr258 merged 1 commit into
developfrom
fix/minimatch-security-2.8.1
Nov 11, 2026
Merged

subodhr258 merged 1 commit into
developfrom
fix/minimatch-security-2.8.1

Conversation

@subodhr258

Copy link
Copy Markdown
Collaborator

Part of 2.8.1, shipping today (11 Nov) with the Black Friday offer notice (#2303).

In one line: Closes Dependabot alert 402 (minimatch, medium, development only) by moving the one vulnerable minimatch copy from 9.0.7 to 11.0.4. The plugin zip does not change.

What changed

File Change
package.json overrides "minimatch@>=9.0.0 <9.0.7": "9.0.7" becomes "minimatch@>=9.0.0 <11.0.1": "11.0.4"; new "@isaacs/nonrecursive-glob-match": "1.0.3" (minimatch 11 needs it)
package-lock.json Only the root minimatch (9.0.7 to 11.0.4) and the new @isaacs/nonrecursive-glob-match 1.0.3. Both from registry.npmjs.org, both more than 48 hours old (11.0.6 and 11.0.7 are newer than that)

Who uses this minimatch copy

The advisory covers >=7.0.0 <11.0.1. Of the 15 minimatch copies, only the root one (9.0.7) was in range. The other 14 are 3.1.5 (eslint, glob 7, test-exclude and others): not affected, unchanged.

User of the root copy Runs when After this PR
@typescript-eslint/typescript-estree 6.21.0 npm run lint:js minimatch 11.0.4; same named minimatch() export; lint passes
glob 10.5.0, under the root jest 30.3.0 Never: Jest 30 is only a peer install for @wordpress/jest-console and @wordpress/jest-preset-default minimatch 11.0.4

npm run test:unit runs @wordpress/scripts' own Jest 29.7.0 (checked with require.resolve from @wordpress/scripts), which uses glob 7 and minimatch 3.1.5. That path does not change.

How it was verified

Node v22.23.4 (.nvmrc), npm 10.9.9, on this branch and on develop:

Check develop this branch
npm ci --ignore-scripts exit 0 exit 0
npm run build:prod exit 0 exit 0, every file in assets/build byte-identical to develop's
npm run test:unit 74 suites, 1007 of 1007 tests pass
wp-scripts lint-js exit 0

Left open

extract-zip (alerts 299 and 319) and deepmerge (alert 397) have no fixed release yet.

Risk

risk: low: development tooling only, no shipped file changes.

minimatch 9.0.7 is in the advisory's range (>=7.0.0 <11.0.1). Its only
users are @typescript-eslint/typescript-estree and the glob 10 under the
root Jest 30 peer install; unit tests run @wordpress/scripts' own Jest 29
(glob 7, minimatch 3.1.5), which is unchanged.
@subodhr258 subodhr258 added the risk: low QA automation only (Dependabot fixes, copy, CSS) label Nov 11, 2026
@github-actions

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
13 0 13

⚠️ Warnings (13)

📁 readme.txt (1 warning)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM".
📁 assets/build/pages/video-editor.min.js (1 warning)
📍 Line 🔖 Check 💬 Message
2 react_removed_api This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/11/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/11/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@subodhr258
subodhr258 merged commit 2bffc77 into develop Nov 11, 2026
4 checks passed
@subodhr258
subodhr258 deleted the fix/minimatch-security-2.8.1 branch November 11, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low QA automation only (Dependabot fixes, copy, CSS)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants