Repository navigation
Bump minimatch to 11.0.4 for Dependabot alert 402 - #2355
Merged
Merged
Conversation
minimatch 9.0.7 is in the advisory's range (>=7.0.0 <11.0.1). Its only users are @typescript-eslint/typescript-estree and the glob 10 under the root Jest 30 peer install; unit tests run @wordpress/scripts' own Jest 29 (glob 7, minimatch 3.1.5), which is unchanged.
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM". |
📁 assets/build/pages/video-editor.min.js (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
2 |
react_removed_api | This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/11/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/11/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
rudrakshi-gupta
approved these changes
Nov 11, 2026
KMchaudhary
approved these changes
Nov 11, 2026
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 2.8.1, shipping today (11 Nov) with the Black Friday offer notice (#2303).
In one line: Closes Dependabot alert 402 (minimatch, medium, development only) by moving the one vulnerable minimatch copy from 9.0.7 to 11.0.4. The plugin zip does not change.
What changed
package.jsonoverrides"minimatch@>=9.0.0 <9.0.7": "9.0.7"becomes"minimatch@>=9.0.0 <11.0.1": "11.0.4"; new"@isaacs/nonrecursive-glob-match": "1.0.3"(minimatch 11 needs it)package-lock.jsonminimatch(9.0.7 to 11.0.4) and the new@isaacs/nonrecursive-glob-match1.0.3. Both from registry.npmjs.org, both more than 48 hours old (11.0.6 and 11.0.7 are newer than that)Who uses this minimatch copy
The advisory covers
>=7.0.0 <11.0.1. Of the 15 minimatch copies, only the root one (9.0.7) was in range. The other 14 are 3.1.5 (eslint, glob 7, test-exclude and others): not affected, unchanged.@typescript-eslint/typescript-estree6.21.0npm run lint:jsminimatch()export; lint passesglob10.5.0, under the rootjest30.3.0@wordpress/jest-consoleand@wordpress/jest-preset-defaultnpm run test:unitruns@wordpress/scripts' own Jest 29.7.0 (checked withrequire.resolvefrom@wordpress/scripts), which uses glob 7 and minimatch 3.1.5. That path does not change.How it was verified
Node v22.23.4 (
.nvmrc), npm 10.9.9, on this branch and ondevelop:npm ci --ignore-scriptsnpm run build:prodassets/buildbyte-identical to develop'snpm run test:unitwp-scripts lint-jsLeft open
extract-zip (alerts 299 and 319) and deepmerge (alert 397) have no fixed release yet.
Risk
risk: low: development tooling only, no shipped file changes.