Skip to content

Develop to main sync for v2.8.1 release - #2356

Merged
subodhr258 merged 4 commits into
mainfrom
develop
Nov 11, 2026
Merged

subodhr258 merged 4 commits into
mainfrom
develop

Conversation

@subodhr258

@subodhr258 subodhr258 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Sync develop to main for the v2.8.1 release (2.8.1), shipping today, Wednesday 11 November. The Black Friday notice must be live before it starts on Friday 13 November.

Includes:

Already on main since the 2.8.0 tag and shipping in 2.8.1 too: #2352 (Node.js moved to a release patched for CVE-2026-111497, build and CI only).

Nothing else is on develop.

Next: after this merges, drytag on main, Plugin Check on the zip, QA, then the 2.8.1 tag.

subodhr258 and others added 3 commits November 11, 2026 10:52
* 2.8.0: Nov 10 date, transcription fixes, caption test ids, JSX runtime build (#2347)

* Move the 2.8.0 date to November 10, 2026

* Transcription: say it usually takes a few minutes, not 10-15

The message shown while an AI transcription runs said it usually takes
10-15 minutes. It usually finishes in a few minutes, so say that, and
that long videos take longer.

* Update the POT for the transcription time message

* Transcription: say it usually takes a few seconds

A preprod test on 9 Nov transcribed 140 seconds of audio in about
3 seconds, so 'a few minutes' was still too long.

* Caption manager: add test ids to the file inputs, row actions and add form

The add and replace file inputs had no id, name or test id, so E2E tests
could only reach them by position. Row actions were only reachable through
a row test id keyed by the caption's id, which a test cannot know ahead.

Rows also carry data-caption-language and data-caption-label, so a test can
find the row for a language or label.

* Regenerate the POT after the caption manager test ids

* Build: resolve react/jsx-runtime to WordPress's React in the admin pages

Packages bundled from node_modules (such as @wordpress/dataviews) import
react/jsx-runtime. The pages build bundled that package, inlining React 18's
element factory into 11 bundles. Elements were then created by a different
copy of React from the one rendering them, and Plugin Check 2.2.0 fails the
build (inlined_react_jsx_runtime), which blocks merges to main.

Resolve the import to pages/jsx-runtime.js, which creates elements with
createElement from the externalized React global. WordPress registers a
shared react-jsx-runtime script only from 6.6, and GoDAM supports 6.5.

* Transcription: keep the cached transcript while the default has no file

Opening the Transcription tab asks Central for the caption list. When the
default caption had no file yet (an AI transcript still pending, or one
that failed), WordPress deleted its cached transcript, so the tab went
empty and the player lost it. Now the cached transcript stays while
Central still lists it; one Central no longer has is still cleared.

* Regenerate the POT after resolving react/jsx-runtime

* Regenerate the POT for the shifted transcription REST lines

* Transcription: say it usually takes a few minutes

"A few seconds" rested on one preprod run, and the panel polls every
8 seconds, so the note stays up longer than the job anyway.

Addresses review: #2347 (comment)

* Caption manager: one helper for a caption's display label

The label-or-language-name fallback was written in five places. It now
lives in captionDisplayLabel(), so data-caption-label and the visible
text can't drift apart. No behaviour change.

Addresses review: #2347 (comment)

* Regenerate the POT for the new transcription message

* Transcription: stop waiting and say why when GoDAM refuses to start

When Central refused a transcription, for example "Transcription limit
exceeded" on an account with no quota left, it gave the reason in
message and left error empty. The editor only read error, so it showed
nothing and kept the spinner running, polling every 8 seconds with no end.

getGenerateRefusal() now treats any success: false answer with no job
running as final and returns error or message. The editor stops waiting
and shows it, or a generic message when Central gave none.

* Regenerate the POT for the transcription refusal fix

* POT: restore the plugin slug in the bug-report header

The last two POT regenerations ran from worktree folders whose names
became the slug in Report-Msgid-Bugs-To. Regenerated with --slug=godam.

* Transcription: compare caption files, not signed URLs; keep an in-flight status

Central signs caption URLs with a fresh token on every request, so the
cached URL never equalled the listed one and the cache was still deleted
on accounts with signed delivery. Compare the file part, before the query
string. Also keep an in-flight status such as Transcribing when nothing
is cached, so the tab opens on the progress state.

Addresses review: #2347 (comment)
Addresses review: #2347 (comment)

* Regenerate the POT for the shifted transcription REST lines

* Keep caption files uploaded before 2.8.0 (#2351)

* Keep caption files uploaded before 2.8.0

2.8.0 marks a caption file uploaded in WordPress with
rtgodam_transcript_source = upload, but uploads from earlier versions
have no mark. They were treated as a cached copy of GoDAM Central's
caption: opening the Transcription tab or the background refresh
overwrote or removed them, and the player played Central's tracks
instead.

An unmarked transcript whose address is not on Central's CDN now counts
as an upload. Generate marks the source as central, so a new
transcript still replaces an old upload.

* Regenerate godam.pot for the shifted transcription line numbers

* Keep the stored caption file until Generate finishes

Generate marked the transcript as Central's as soon as a job started,
so while the job ran, or after it failed, the caption sync saw an
unlisted Central copy and removed the uploaded file the video used.

Generate now marks a running job central-pending: the stored file is
kept and played as an upload until Central reports a ready default,
which then replaces it and marks it central. Every write of Central's
transcript (sync, callback, godam_get_transcript_path) now marks it
central too, so the address check only decides for transcripts stored
before 2.8.0. The rtgodam_transcoder_file_hosts docblock says so.

Regenerate godam.pot for the shifted line references.

* fix: move Node.js to a release patched for CVE-2026-111497

---------

Co-authored-by: Rudrakshi Gupta <109859631+rudrakshi-gupta@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Kuldip Chaudhary <64731232+KMchaudhary@users.noreply.github.com>
Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>
Co-authored-by: rtBot <43742164+rtBot@users.noreply.github.com>
Co-authored-by: Immanuel Raj <iamimmanuelraj@gmail.com>
minimatch 9.0.7 is in the advisory's range (>=7.0.0 <11.0.1). Its only
users are @typescript-eslint/typescript-estree and the glob 10 under the
root Jest 30 peer install; unit tests run @wordpress/scripts' own Jest 29
(glob 7, minimatch 3.1.5), which is unchanged.
…to December 3 (#2303)

* Show the Black Friday offer notice from November 15 to 27

The offer notice now runs a list of dated campaigns. Halloween keeps
showing through November 9; nothing shows from November 10 to 14; the
Black Friday 2026 offer (code BFCM2026) shows from 00:00:00 on
November 15 to 23:59:59 on November 27 in the site's time zone, then
ends by itself.

Black Friday has its own dismiss option, copy, godam.io/deals/ link with
bfcm2026 tracking, and no Halloween art.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Read the clock once per render; keep Halloween's old start

render() read the clock twice, so a campaign ending between the two
reads could leave no campaign to render. Halloween's start moves to
October 1, so it still shows from install as before. Adds a test for a
dismiss between campaigns and for the AJAX call with no time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Run the Black Friday notice from November 14 to 30

Cyber Monday is November 30, so the campaign window is now
November 14 00:00:00 to November 30 23:59:59 in the site's time zone.
The footer says "Ends November 30 at 11:59 p.m.".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Name both Black Friday and Cyber Monday in the offer notice

The eyebrow now reads "Black Friday and Cyber Monday offer" and the title
"Black Friday and Cyber Monday deal: Get 50% off GoDAM". Dates, code and
tests are unchanged apart from the expected strings.

* Start the Black Friday notice on November 13

The campaign now runs November 13 00:00:00 to November 30 23:59:59
in the site's time zone. The footer ("Ends November 30") is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* End the Black Friday notice on December 3

The sale window is now November 13 to December 3, so the notice keeps
showing for three days after Cyber Monday (November 30).

* Point the Black Friday Claim button to godam.io/pricing/

godam.io/deals/ does not exist (404), so the button now opens the
pricing page, like the Halloween notice and the godam.io top bar.

* Replace the ended Halloween offer with Black Friday

Halloween 2026 ended on November 9, so its campaign entry, copy, spider
and pumpkin drawings and their styles are removed. Black Friday is now
the only campaign; the next offer replaces it the same way. Tests move
to Black Friday dates and check that Halloween never shows again.

* fix: tag the campaign list and get_campaign() with @SInCE 2.8.1

Addresses review: #2303 (comment)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
13 0 13

⚠️ Warnings (13)

📁 readme.txt (1 warning)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM".
📁 assets/build/pages/video-editor.min.js (1 warning)
📍 Line 🔖 Check 💬 Message
2 react_removed_api This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/11/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/11/11/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

Plugin header, RTGODAM_VERSION, Stable tag, package.json and
package-lock.json, POT (slug godam), and the v2.8.1 changelog in
readme.txt and CHANGELOG.md, dated November 11, 2026. The changelog
lists the security fixes only; v2.6.2 drops out of readme.txt.
@subodhr258
subodhr258 merged commit 1ced16e into main Nov 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium Agent QA plus a human spot check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants