Treat iterator collect lengths as hints#9805
Open
eluvane wants to merge 3 commits into
Open
Conversation
…hint-safe # Conflicts: # src/cli/main.zig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR treats iterator size hints as allocation hints when collecting into lists.
The Iter and Stream collect paths still reserve from Known(n) up front, but they now append through the reserving List.append path. Iter.custom also stops decrementing a depleted Known hint after an over-producing custom iterator yields again, so a too-small user-supplied hint degrades to Unknown instead of crashing.
A regression test builds a custom iterator that reports Known(8) while yielding nine items and checks that Iter.collect returns the full list. The collect worker shape test was updated for the simpler single-append loop.
The hot-reload descriptor test helper now uses the descriptor write path, so descriptor memory is committed before writes on Windows.