Materialize compile-time constants as static data#9771
Closed
rtfeldman wants to merge 434 commits into
Closed
Conversation
A constant list literal consumed through .iter() is materialized as static data, so the whole minted chain including the base list allocates nothing on the --opt=size cart path. Add a wasm-static-lib gate asserting --max-allocs 0 for the full list.iter().append().append() for-loop pattern, which the existing --assert-alloc-balanced iter_for gate cannot catch (a heap-built base list would allocate-and-free yet stay balanced).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds explicit static-data references for reachable compile-time constants, materializes those constants into backend data objects, and teaches the wasm/native backends to use those symbols instead of rebuilding constants at runtime. It also updates wasm target config to model imported memory as No, Uninitialized, or Zeroed, wires Binaryen optimization into wasm size/speed builds, and adds regression coverage for hoisted constants, static data emission, and unused top-level compile-time evaluation.