Skip to content

Address truncation in interactive histogram X-axis ruler #6562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andersendsa wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Address truncation in interactive histogram X-axis ruler #6562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50f02f
Fix address truncation in interactive histogram X-axis ruler
andersendsa Jun 26, 2026
89bc19b
fix ci failure
andersendsa Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions librz/cons/histogram.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,14 +712,12 @@ static void render_visual_xaxis_ruler(RzStrBuf *buf, const RzHistogramInteractiv
int realj, max_room, wrote;
ut64 off;
char label[32] = { 0 };
if ((int)c < start_col) {
rz_strbuf_appendf(buf, "%*s", start_col - (int)c, "");
c = (ut32)start_col;
}

// Calculate label value early to know its length before padding
if (sizeofonebar > 1) {
realj = adder + (int)c / sizeofonebar;
realj = adder + start_col / sizeofonebar;
} else {
realj = adder + (int)((ut64)c * histogramwidth / ((ut64)zoom * width));
realj = adder + (int)((ut64)start_col * histogramwidth / ((ut64)zoom * width));
}
if (realj < 0) {
realj = 0;
Expand All @@ -729,11 +727,31 @@ static void render_visual_xaxis_ruler(RzStrBuf *buf, const RzHistogramInteractiv
off = opts->offpos + (ut64)realj * hist->blocksize;
rz_strf(label, "0x%" PFMT64x, off);
wrote = (int)strlen(label);

// If this is the last tick, shift start_col to the left so the whole label fits
if (t + 1 == ticks && wrote > 0) {
int new_start = (int)data_cols - wrote;
if (new_start < 0) {
new_start = 0;
}
if (t > 0 && new_start <= tick_cols[t - 1]) {
new_start = tick_cols[t - 1] + 1;
}
if (new_start < start_col && (int)c <= new_start) {
start_col = new_start;
}
}

if ((int)c < start_col) {
rz_strbuf_appendf(buf, "%*s", start_col - (int)c, "");
c = (ut32)start_col;
}

// Truncate if the label would overflow into the next tick.
if (t + 1 < ticks) {
max_room = tick_cols[t + 1] - start_col - 1;
} else {
max_room = (int)data_cols - start_col;
max_room = sizeof(label);
}
if (max_room < 1) {
max_room = 1;
Expand Down
Loading