Address truncation in interactive histogram X-axis ruler#6562
Address truncation in interactive histogram X-axis ruler#6562andersendsa wants to merge 2 commits into
Conversation
The interactive horizontal histogram (`p==`) truncated the rightmost address offset on the X-axis ruler to a single character (e.g. `0` instead of `0x...`) because `max_room` for the last label tick was constrained to `data_cols - start_col`. This commit replaces the `max_room` calculation for the last tick so that it does not aggressively truncate the label, allowing the full address to be displayed correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 40 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Rot127
left a comment
There was a problem hiding this comment.
Add before and after screenshots please.
@Rot127 After
|
|
Hi @Rot127 could you pls review the the pr and help me identify the changes that are needed ? |
i'm sorry. these images are identical. |
|
That's definitely not an actual screenshot. |




Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
The interactive horizontal histogram (
p==) truncated the rightmost address offset on the X-axis ruler to a single character (e.g.0instead of0x...) becausemax_roomfor the last label tick was constrained todata_cols - start_col.This commit replaces the
max_roomcalculation for the last tick so that it does not aggressively truncate the label, allowing the full address to be displayed correctly....
Test plan
ninja -C build.rizinand view interactive histogram usingp== <size>.0x1000instead of0).ninja -C build testor specificallycd test && rz-test db/cmd/cmd_print....
Closing issues
Closes:. #6550
...