Skip to content

Remove local @types/google-apps-script in favor of ^2.0.12 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thromer merged 1 commit into from
Aug 3, 2026
Merged

Remove local @types/google-apps-script in favor of ^2.0.12 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ enableScripts: false
nodeLinker: node-modules

npmMinimalAgeGate: 1w
npmPreapprovedPackages:
- "@types/google-apps-script@2.0.12"
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "empower-poster",
"private": true,
"license": "MIT",
"packageManager": "yarn@4.17.0",
"packageManager": "yarn@4.18.0",
"workspaces": [
"packages/*"
],
Expand Down
2 changes: 1 addition & 1 deletion packages/apps-script-minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"devDependencies": {
"@rollup/plugin-node-resolve": "^16.0.3",
"@rollup/plugin-typescript": "^12.3.0",
"@types/google-apps-script": "^2.0.11",
"@types/google-apps-script": "^2.0.12",
"eslint": "^10.1.0",
"prettier": "^3.8.1",
"rollup": "^4.61.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/apps-script-portfolio-tracker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"devDependencies": {
"@rollup/plugin-node-resolve": "^16.0.3",
"@rollup/plugin-typescript": "^12.3.0",
"@types/google-apps-script": "^2.0.11",
"@types/google-apps-script": "^2.0.12",
"eslint": "^10.1.0",
"prettier": "^3.8.1",
"rollup": "^4.61.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/apps-script-portfolio-tracker/src/sheet-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function makeTableHelper(
if (typeof Sheets === "undefined") {
throw new OurError("Must enable Sheets service");
}
const sheetsService = Sheets as MyGoogleAppsScript.Sheets;
const sheetsService = Sheets as GoogleAppsScript.Sheets;
return new TableHelper(sheetsService, spreadsheetId, sheet, tableName);
} catch (e) {
if (e instanceof OurError) {
Expand Down Expand Up @@ -58,15 +58,15 @@ interface TableHelperState {
}

class TableHelper {
private sheetsService: MyGoogleAppsScript.Sheets;
private sheetsService: GoogleAppsScript.Sheets;
private spreadsheetId: string;
private sheet: GoogleAppsScript.Spreadsheet.Sheet;
private tableName: string;
private state: TableHelperState;
private isFormulaTable: boolean;
private lastRowAdjustment: 0 | 1; // 1 for formula tables, to preserve default last row
constructor(
sheetsService: MyGoogleAppsScript.Sheets,
sheetsService: GoogleAppsScript.Sheets,
spreadsheetId: string,
sheet: GoogleAppsScript.Spreadsheet.Sheet,
tableName: string,
Expand Down
1 change: 0 additions & 1 deletion packages/apps-script-portfolio-tracker/src/vendor/README.md
View file
Open in desktop

This file was deleted.

1,675 changes: 0 additions & 1,675 deletions packages/apps-script-portfolio-tracker/src/vendor/sheets_v4.d.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/extension/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"skipLibCheck": true,
"strict": true,
"target": "ESNext",
"types": ["chrome"],
"useDefineForClassFields": true,
"verbatimModuleSyntax": true
},
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,10 +636,10 @@ __metadata:
languageName: node
linkType: hard

"@types/google-apps-script@npm:^2.0.11":
version: 2.0.11
resolution: "@types/google-apps-script@npm:2.0.11"
checksum: 10c0/1c29a8462b106c8176e2839a9dcb0d6b39403e3026ce76e832b459fbf7f5787f4d98fa21540f05147cf6e0c3a4cbc7e81199ce2f554f2f2bd25066384ce05138
"@types/google-apps-script@npm:^2.0.12":
version: 2.0.12
resolution: "@types/google-apps-script@npm:2.0.12"
checksum: 10c0/d99aea5da8679ca43057b62a1b8b4f7f0e4ec044bbb59d86b3f6caf3a71d40fb1ddac9437a6980905d2f5e58a93e603f89825ee7ac8f82306335f5990530edf5
languageName: node
linkType: hard

Expand Down Expand Up @@ -956,7 +956,7 @@ __metadata:
dependencies:
"@rollup/plugin-node-resolve": "npm:^16.0.3"
"@rollup/plugin-typescript": "npm:^12.3.0"
"@types/google-apps-script": "npm:^2.0.11"
"@types/google-apps-script": "npm:^2.0.12"
eslint: "npm:^10.1.0"
prettier: "npm:^3.8.1"
rollup: "npm:^4.61.1"
Expand All @@ -973,7 +973,7 @@ __metadata:
dependencies:
"@rollup/plugin-node-resolve": "npm:^16.0.3"
"@rollup/plugin-typescript": "npm:^12.3.0"
"@types/google-apps-script": "npm:^2.0.11"
"@types/google-apps-script": "npm:^2.0.12"
eslint: "npm:^10.1.0"
prettier: "npm:^3.8.1"
rollup: "npm:^4.61.1"
Expand Down Expand Up @@ -2033,15 +2033,15 @@ __metadata:

"resolve@patch:resolve@npm%3A^1.22.1#optional!builtin<compat/resolve>":
version: 1.22.12
resolution: "resolve@patch:resolve@npm%3A1.22.12#optional!builtin<compat/resolve>::version=1.22.12&hash=c3c19d"
resolution: "resolve@patch:resolve@npm%3A1.22.12#optional!builtin<compat/resolve>::version=1.22.12&hash=9bd1a5"
dependencies:
es-errors: "npm:^1.3.0"
is-core-module: "npm:^2.16.1"
path-parse: "npm:^1.0.7"
supports-preserve-symlinks-flag: "npm:^1.0.0"
bin:
resolve: bin/resolve
checksum: 10c0/fc6519984ae1f894d877c0060ba8b1f5ba3bc0e85a02f74e141929c118c23d74d9735619a9cc2965397387e514884245c65d72a40731dcb6cfc84c7bcdc8321e
checksum: 10c0/e12af106e16e652bd83060e8afacece4ee3dcbd0f4cf028e3d9ad178e6ced9ecb1c87ee60158b239582313902a717f8adc57a9b76ea54b1994141ba15f420c65
languageName: node
linkType: hard

Expand Down