Skip to content

Remove local @types/google-apps-script in favor of ^2.0.12 - #25

Merged
thromer merged 1 commit into
mainfrom
dev
Aug 3, 2026
Merged

Remove local @types/google-apps-script in favor of ^2.0.12#25
thromer merged 1 commit into
mainfrom
dev

Conversation

@thromer

@thromer thromer commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes #24.

Summary by CodeRabbit

  • Improvements

    • Updated Google Apps Script type definitions for improved compatibility with current Sheets APIs.
    • Removed obsolete bundled Sheets API declarations.
    • Improved browser extension TypeScript configuration for Chrome API support.
  • Maintenance

    • Updated the project’s package manager tooling.
    • Added configuration to support the latest approved Apps Script type package.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7fbf2833-1773-49b7-9c65-6a718b316bb6

📥 Commits

Reviewing files that changed from the base of the PR and between 86e3e05 and d7911fb.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (8)
  • .yarnrc.yml
  • package.json
  • packages/apps-script-minimal/package.json
  • packages/apps-script-portfolio-tracker/package.json
  • packages/apps-script-portfolio-tracker/src/sheet-utils.ts
  • packages/apps-script-portfolio-tracker/src/vendor/README.md
  • packages/apps-script-portfolio-tracker/src/vendor/sheets_v4.d.ts
  • packages/extension/tsconfig.json
💤 Files with no reviewable changes (2)
  • packages/apps-script-portfolio-tracker/src/vendor/README.md
  • packages/apps-script-portfolio-tracker/src/vendor/sheets_v4.d.ts

📝 Walkthrough

Walkthrough

The project upgrades Yarn and Google Apps Script types, replaces vendored Sheets declarations with built-in types, removes the vendor declarations, and enables Chrome types for the extension.

Changes

Apps Script and extension tooling

Layer / File(s) Summary
Dependency and Yarn updates
.yarnrc.yml, package.json, packages/apps-script-minimal/package.json, packages/apps-script-portfolio-tracker/package.json
Yarn updates to 4.18.0. Both Apps Script packages use @types/google-apps-script 2.0.12. The new package version is preapproved.
Built-in Sheets type migration
packages/apps-script-portfolio-tracker/src/sheet-utils.ts, packages/apps-script-portfolio-tracker/src/vendor/sheets_v4.d.ts, packages/apps-script-portfolio-tracker/src/vendor/README.md
Sheets utilities use GoogleAppsScript.Sheets. The vendored Sheets declarations and related removal note are deleted.
Chrome compiler types
packages/extension/tsconfig.json
TypeScript includes Chrome type definitions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The change to packages/extension/tsconfig.json is not related to eliminating the Apps Script vendor package. Remove the unrelated tsconfig change or document why the Chrome type configuration is required for issue #24.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes replacing the local Google Apps Script types with version ^2.0.12.
Linked Issues check ✅ Passed The PR removes the vendor declarations and updates references and dependencies to eliminate the local package as required by issue #24.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thromer
thromer merged commit 41187d0 into main Aug 3, 2026
8 checks passed
@thromer
thromer deleted the dev branch August 3, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate packages/apps-script-portfolio-tracker/src/vendor

1 participant