Conversation
- Add install step to top-level yarn ci script. - ...
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR replaces ChangesConsole to Logger.log migration
Build, package, and config updates
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitignore:
- Around line 30-31: The ignore rule in the root .gitignore is too broad and
will match files across the entire repository. Update the rule so it is scoped
only to the intended clasp workspace, or move the ignore entry into that
subdirectory’s own .gitignore; use the current unqualified pattern as the item
to locate and narrow.
In @.yarnrc.yml:
- Around line 1-3: The approvedGitRepositories setting is overly permissive
because it uses a wildcard allowlist. Update the .yarnrc.yml configuration to
replace the generic "**" entry with only the specific repository URLs or
organization patterns that should be trusted, keeping the
approvedGitRepositories setting constrained to known sources.
- Line 10: Restore the npm freshness safeguard by changing the npmMinimalAgeGate
setting in the Yarn config to a non-zero value. Keep the existing configuration
structure intact and update only the npmMinimalAgeGate entry so the project
continues to block newly published packages unless this behavior is explicitly
intended.
In `@package.json`:
- Around line 9-10: The ci script currently invokes a bare install through yarn
workspaces foreach -A install, which runs each workspace’s install command
instead of performing dependency installation. Update the package.json scripts
entry for ci to remove that install step and leave only the intended workspace
CI execution via yarn workspaces foreach -A run ci, so the script no longer
relies on a no-op workspace command.
In `@packages/extension/cli/cli.ts`:
- Line 22: The CLI output in cli.ts is using Logger.log, but this module has no
Logger shim in Node and will fail at runtime with Logger undefined. Update the
logging in the CLI entrypoint to use a Node-safe logger such as console.log, or
introduce an explicit logger dependency that is defined in this runtime. Keep
the JSON payload for holdings and classifications unchanged while replacing the
logging call.
In `@packages/extension/src/background.ts`:
- Around line 12-15: The background service worker is using Logger, which is not
available in the extension runtime and can break listener registration at
startup. Update the logging in background.ts at the top-level startup code and
the related onInstalled handler, along with the other Logger call sites in the
same module, to use a browser-safe logger such as console.log or a shared
wrapper that is safe in extension contexts. Make sure the change is applied
consistently across the Background script’s logging points so the module can
load without runtime errors.
In `@packages/extension/src/config-form.ts`:
- Line 94: Replace the save-error logging in the config form with console.log
instead of Logger.log, since Logger is not available in this extension page and
causes a ReferenceError after the message is shown. Update the error-handling
path in config-form’s save flow to use console.log for msg, keeping the rest of
the save logic unchanged.
In `@packages/extension/src/content.ts`:
- Around line 108-111: `content.ts` is calling `Logger.log` even though `Logger`
is not available in the extension bundle, so the error path will fail at
runtime. Update the logging in the `classificationsErrors` handling block to use
a browser-safe logger such as `console.log` or `console.error` instead, and make
the same replacement for both `Logger` call sites in `content.ts`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ff018236-6627-48ad-ac21-4a8e9c4b237a
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (12)
.gitignore.yarnrc.ymlpackage.jsonpackages/apps-script-sample/clasp-redeploy.shpackages/apps-script-sample/package.jsonpackages/apps-script-sample/src/app.tspackages/extension/cli/cli.tspackages/extension/package.jsonpackages/extension/src/background.tspackages/extension/src/config-form.tspackages/extension/src/content.tspackages/extension/tests/processing.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Bug Fixes