Skip to content

[about] Localize package #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
confused-Techie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[about] Localize package #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/about/lib/components/about-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ module.exports = class AboutView extends EtchComponent {
var showMoreDiv = document.querySelector('.show-more');
var showMoreText = document.querySelector('.about-more-expand');
switch (showMoreText.textContent) {
case 'Show more':
case atom.i18n.t("about.src.show-more"):
showMoreDiv.classList.toggle('hidden');
showMoreText.textContent = 'Hide';
showMoreText.textContent = atom.i18n.t("about.src.hide");
break;
case 'Hide':
case atom.i18n.t("about.src.hide"):
showMoreDiv.classList.toggle('hidden');
showMoreText.textContent = 'Show more';
showMoreText.textContent = atom.i18n.t("about.src.show-more");
break;
}
}
Expand Down Expand Up @@ -108,7 +108,7 @@ module.exports = class AboutView extends EtchComponent {
className: 'about-header-release-notes',
onclick: this.handleReleaseNotesClick.bind(this)
},
'Release Notes'
atom.i18n.t("about.src.release-notes")
)
),
$.span(
Expand All @@ -117,7 +117,7 @@ module.exports = class AboutView extends EtchComponent {
'about-version-container show-more-expand',
onclick: this.handleShowMoreClick.bind(this)
},
$.span({ className: 'about-more-expand' }, 'Show more')
$.span({ className: 'about-more-expand' }, atom.i18n.t("about.src.show-more"))
),
$.div(
{ className: 'show-more hidden about-more-info' },
Expand Down Expand Up @@ -177,15 +177,15 @@ module.exports = class AboutView extends EtchComponent {
{ className: 'about-updates-item app-unsupported' },
$.span(
{ className: 'about-updates-label is-strong' },
'Updates have been moved to the package ', $.code({style: {'white-space': 'nowrap'}}, 'pulsar-updater'), '.',
atom.i18n.t("about.src.updates-have-moved"), " ", $.code({style: {'white-space': 'nowrap'}}, 'pulsar-updater'), '.',
$.br()
),
$.a(
{
className: 'about-updates-instructions',
onclick: this.handleHowToUpdateClick.bind(this)
},
'How to update'
atom.i18n.t("about.src.how-to-update")
)
)
),
Expand All @@ -202,7 +202,7 @@ module.exports = class AboutView extends EtchComponent {
className: 'btn view-license',
onclick: this.handleLicenseClick.bind(this)
},
'License'
atom.i18n.t("about.src.license")
),
//Disabled the below as we don't have this but can reuse if there is the need
/*$.button(
Expand Down Expand Up @@ -233,7 +233,7 @@ module.exports = class AboutView extends EtchComponent {
{ className: 'about-updates-item app-unsupported' },
$.span(
{ className: 'about-updates-label is-strong' },
'Enable `pulsar-updater` to check for updates'
atom.i18n.t("about.src.enable-pulsar-updater")
)
);
} else {
Expand All @@ -246,7 +246,7 @@ module.exports = class AboutView extends EtchComponent {
margin: '0 .5em'
}
},
'Check Now'
atom.i18n.t("about.src.check-now")
);
}
}
Expand All @@ -267,7 +267,7 @@ module.exports = class AboutView extends EtchComponent {
}

getTitle() {
return 'About';
return atom.i18n.t("about.src.about-view-title");
}

getIconName() {
Expand Down
11 changes: 11 additions & 0 deletions packages/about/locales/about.en.cson
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'src': {
'show-more': 'Show more'
'hide': 'Hide'
'release-notes': 'Release Notes'
'updates-have-moved': 'Updates have been moved to the package'
'how-to-update': 'How to update'
'license': 'License'
'enable-pulsar-updater': 'Enable `pulsar-updater` to check for updates'
'check-now': 'Check Now'
'about-view-title': 'About'
}
Loading