Skip to content

Fix Localization Oversights in 3 Texts #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deokishisu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Localization Oversights in 3 Texts #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data/maps/CeladonCity_DepartmentStore_Roof/text.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
CeladonCity_DepartmentStore_Roof_Text_ImThirstyGiveHerDrink::
.string "I'm thirsty!\n"
.string "I want something to drink!\p"
#ifdef BUGFIX @ The localizers missed what should be a textcolor change in the localizations.
.string "{COLOR DARK_GRAY}Give her a drink?$"
#else @ In the JP games, gender-based text used a different font instead of different colors.
.string "{FONT_NORMAL}Give her a drink?$"
#endif

CeladonCity_DepartmentStore_Roof_Text_GiveWhichDrink::
.string "Give her which drink?$"
Expand Down
5 changes: 4 additions & 1 deletion data/maps/CinnabarIsland_PokemonLab_ExperimentRoom/text.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,14 @@ CinnabarIsland_PokemonLab_ExperimentRoom_Text_ThatFossilIsOfMonMakeItLiveAgain::
.string "My Resurrection Machine will make\n"
.string "that POKéMON live again!$"

@ TODO: Resolve text dump error below?
CinnabarIsland_PokemonLab_ExperimentRoom_Text_HandedFossilToWeirdDoctor::
.string "So!\n"
.string "You hurry and give me that!\p"
#ifdef BUGFIX @ The localizers missed what should be a textcolor change in the localizations.
.string "{COLOR DARK_GRAY}{PLAYER} handed over the\n"
#else @ In the JP games, gender-based text used a different font instead of different colors.
.string "{FONT_NORMAL}{PLAYER} handed over the\n"
#endif
.string "{STR_VAR_2} to the weird doctor.$"

CinnabarIsland_PokemonLab_ExperimentRoom_Text_TakesTimeGoForWalk::
Expand Down
11 changes: 11 additions & 0 deletions data/maps/VermilionCity/text.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,25 @@ VermilionCity_Text_DoYouHaveATicket::
.string "Excuse me, do you have a ticket?$"

VermilionCity_Text_FlashedSSTicket::
#ifdef BUGFIX @ The localizers missed what should be a textcolor change in the localizations.
.string "{COLOR DARK_GRAY}{PLAYER} flashed the S.S. TICKET!\p"
.string "{COLOR BLUE}Great!\n"
#else @ In the JP games, gender-based text used a different font instead of different colors.
.string "{FONT_NORMAL}{PLAYER} flashed the S.S. TICKET!\p"
.string "{FONT_MALE}Great!\n"
#endif
.string "Welcome to the S.S. ANNE!$"

VermilionCity_Text_DontHaveNeededSSTicket::
#ifdef BUGFIX @ The localizers missed what should be a textcolor change in the localizations.
.string "{COLOR DARK_GRAY}{PLAYER} doesn't have the needed\n"
.string "S.S. TICKET.\p"
.string "{COLOR BLUE}Sorry!\p"
#else @ In the JP games, gender-based text used a different font instead of different colors.
.string "{FONT_NORMAL}{PLAYER} doesn't have the needed\n"
.string "S.S. TICKET.\p"
.string "{FONT_MALE}Sorry!\p"
#endif
.string "You need a ticket to get aboard.$"

VermilionCity_Text_TheShipSetSail::
Expand Down