Fix Localization Oversights in 3 Texts - #771
Open
Deokishisu wants to merge 1 commit into
Open
Conversation
The fossil revival scientist's text for handing over a fossil in Cinnabar Lab, the ferryman checking the S.S. Ticket texts in Vermilion City, and the thirsty girl text on Celadon Dept. Store's rooftop all had font changes (as the original Japanese does) instead of textcolor changes embedded in their strings. If the localizers had caught them, they would've replaced `FONT_NORMAL` with `COLOR DARK_GRAY` and `FONT_MALE` with `COLOR BLUE`. This commit creates a #ifdef BUGFIX for each of these oversights. These issues are present in all localization languages. Looks like nobody caught them.
Deokishisu
changed the title
Contributor
Author
|
I squashed into one commit for all three changes and force pushed. This is what I get for rushing to make a commit and PR before fully investigating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fossil revival scientist's text for handing over a fossil in Cinnabar Lab, the ferryman checking the S.S. Ticket texts in Vermilion City, and the thirsty girl text on Celadon Dept. Store's rooftop all had font changes (as the original Japanese does) instead of textcolor changes embedded in their strings.
If the localizers had caught them, they would've replaced
FONT_NORMALwithCOLOR DARK_GRAYandFONT_MALEwithCOLOR BLUE. This commit creates a #ifdef BUGFIX for each of these oversights.These issues are present in all localization languages. Looks like nobody caught them.