Skip to content

Add Moonfield Archive collectible-card binder and free packs - #198

Merged
VesaJuvonen merged 2 commits into
pnp:mainfrom
GavinWarner05:codex/moonfield-archive
Oct 22, 2026
Merged

VesaJuvonen merged 2 commits into
pnp:mainfrom
GavinWarner05:codex/moonfield-archive

Conversation

@GavinWarner05

Copy link
Copy Markdown

By submitting this pull request, you agree to the contribution guidelines.

  • Bug fix?
  • New sample?
  • Related issues: none found.
  • Needs API permissions? No connectors or external API scopes.
  • Has other prerequisites? Power Apps entitlement and maker permissions; Dataverse-enabled development environment for solution import.

What's in this Pull Request?

Adds a three-screen canvas app with twelve original fictional cards. Unlimited free three-card packs show 60/25/12/3 rarity odds, award unique missing cards before reveal, and distinguish New from Already owned without duplicate quantities. The binder combines ownership, rarity and search filters with completion progress; details show artwork and lore.

Ownership uses device-local SaveData/LoadData with an explicit save-failure warning and retry. Includes the Studio-exported app, unmanaged solution 1.0.0.3, extracted source, original SVGs, real player screenshots and setup/architecture notes. No purchases, currency, connectors or server provisioning are required by the app.

Validation: 22 local reference/source checks pass. Real Studio/player tests cover rarity boundaries, duplicate handling, repeated clicks, pre-reveal saving, mid-reveal navigation/reload and reset persistence. Export/unpack/repack and embedded/standalone source parity passed. Both exports have zero parser/binding errors and zero accessibility warnings; one intentional twelve-row catalogue advisory remains. The unchanged 1.0.0.3 solution imported successfully as New in a clean Developer target on 2026-10-18, and imported-player smoke tests passed; full screen-reader, phone and cross-browser coverage is not claimed.

Testing limitation: the first observed imported-player state contained 2/12 saved cards for an unestablished reason. A confirmed reset established the runtime-test baseline; pristine first-ever launch with an empty collection is not claimed.

Checklist

  • My pull request affects only ONE sample.
  • My sample includes a completed assets/sample.json metadata file.
  • I have updated the sample's README.md.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF).
  • My README contains complete setup instructions, including prerequisites and required permissions.
  • The final line of my README contains the required repository-relative visitor stats image.

Clean-target validation

  • Imported final 1.0.0.3 solution into a separate approved Developer target and recorded actual player results, including duplicates, interrupted reveal/reload, filters, navigation and reset.

@github-actions

Copy link
Copy Markdown

Validation failed!

File: samples/collectible-card-binder/assets/sample.json

  • Invalid value '' for author's 'pictureUrl' property: Object reference not set to an instance of an object.

@GavinWarner05
GavinWarner05 marked this pull request as ready for review October 18, 2026 03:55

@VesaJuvonen VesaJuvonen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current sample metadata, README/setup paths, source and unmanaged solution structure, and the recorded validation evidence. The earlier avatar metadata problem is resolved in the current head. The documented device-local persistence, layout, and clean-target validation limitations remain explicit; this review does not claim a fresh tenant import.

@VesaJuvonen
VesaJuvonen merged commit c036df4 into pnp:main Oct 22, 2026
1 check passed
@VesaJuvonen

Copy link
Copy Markdown
Collaborator

Merged - thank you @GavinWarner05 for sharing Moonfield Archive and the detailed validation notes! Please submit a demo request at https://aka.ms/community/request/demo so we can schedule you for a live demo in a Microsoft 365 & Power Platform community call. We would love to see the sample in action.

@VesaJuvonen

Copy link
Copy Markdown
Collaborator

Follow-up validation: I ran all 22 dependency-free reference/source tests locally. Windows exposed three decoding errors in the test helpers due to the platform-default text encoding; #199 makes those reads explicitly UTF-8, after which all 22 tests pass. This does not change the app or claim fresh Power Fx/tenant execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants