Skip to content

fix:(Fixed nil pointer crash when adding remote candidate) #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kesha005 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix:(Fixed nil pointer crash when adding remote candidate) #1057

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bcc06e
Fixed nil pointer crash when adding remote candidate
Kesha005 Nov 3, 2026
588c6f7
Fix gofumpt and whitespace lint errors
Kesha005 Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions examples/ping-pong/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ func remoteCandidate(_ http.ResponseWriter, r *http.Request) {
panic(err)
}

if err := iceAgent.AddRemoteCandidate(c); err != nil { //nolint:contextcheck
panic(err)
if c != nil {
if err := iceAgent.AddRemoteCandidate(c); err != nil { //nolint:contextcheck
panic(err)
}
}
}

Expand All @@ -70,6 +72,11 @@ func main() { //nolint
remoteHTTPPort = 9000
}

iceAgent, err = ice.NewAgent()
if err != nil {
panic(err)
}

http.HandleFunc("/remoteAuth", remoteAuth)
http.HandleFunc("/remoteCandidate", remoteCandidate)
go func() {
Expand All @@ -88,11 +95,6 @@ func main() { //nolint
panic(err)
}

iceAgent, err = ice.NewAgent()
if err != nil {
panic(err)
}

// When we have gathered a new ICE Candidate send it to the remote peer
if err = iceAgent.OnCandidate(func(c ice.Candidate) {
if c == nil {
Expand Down
Loading