Skip to content

fix:(Fixed nil pointer crash when adding remote candidate) - #1057

Open
Kesha005 wants to merge 2 commits into
pion:mainfrom
Kesha005:fix-examples-ping-pong
Open

Kesha005 wants to merge 2 commits into
pion:mainfrom
Kesha005:fix-examples-ping-pong

Conversation

@Kesha005

@Kesha005 Kesha005 commented Nov 3, 2026

Copy link
Copy Markdown

Description

Bug fix on examples/ping-pong. Error occurs when trying to add remote candidate.

Fix #1056

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.71%. Comparing base (2981def) to head (588c6f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
+ Coverage   91.66%   91.71%   +0.05%     
==========================================
  Files          45       45              
  Lines        5456     5456              
==========================================
+ Hits         5001     5004       +3     
+ Misses        455      452       -3     
Flag Coverage Δ
go 91.71% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kesha005
Kesha005 force-pushed the fix-examples-ping-pong branch from 03169ac to 588c6f7 Compare November 3, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Examples: ping-pong crash after Enter

2 participants