Skip to content

Promote Copy TSV to a standalone toolbar button #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbalicki2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote Copy TSV to a standalone toolbar button #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions querybook/webapp/components/StatementExecutionBar/ResultExportDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,26 +200,6 @@ export const ResultExportDropdown: React.FunctionComponent<IProps> = ({
onClick: onDownloadClick,
icon: 'Download',
},
{
name: (
<span>
Copy{' '}
{isPreviewFullResult(
statementExecution,
statementResult
) ? (
'Full Result'
) : (
<span style={{ color: 'var(--color-accent-dark)' }}>
Preview
</span>
)}{' '}
to Clipboard (as TSV)
</span>
),
onClick: onExportTSVClick,
icon: 'Copy',
},
...(hasMetastoresForUpload
? [
{
Expand Down Expand Up @@ -282,6 +262,23 @@ export const ResultExportDropdown: React.FunctionComponent<IProps> = ({
</Dropdown>
);

const copyTSVButton = (
<TextButton
size="small"
onClick={onExportTSVClick}
icon="Copy"
disabled={
!statementExecution || statementExecution.result_row_count === 0
}
title={
statementExecution &&
isPreviewFullResult(statementExecution, statementResult)
? 'Copy Full Result'
: 'Copy Preview'
}
/>
);

const tableUploadForm = showTableUploadForm && (
<TableUploaderForm
onHide={() => setShowTableUploadForm(false)}
Expand All @@ -291,6 +288,7 @@ export const ResultExportDropdown: React.FunctionComponent<IProps> = ({

return (
<>
{copyTSVButton}
{ellipsesDropDownButton}
{formModal}
{tableUploadForm}
Expand Down