Skip to content

Promote Copy TSV to a standalone toolbar button#1727

Open
rbalicki2 wants to merge 1 commit into
pinterest:masterfrom
rbalicki2:copy-tsv-button
Open

Promote Copy TSV to a standalone toolbar button#1727
rbalicki2 wants to merge 1 commit into
pinterest:masterfrom
rbalicki2:copy-tsv-button

Conversation

@rbalicki2

Copy link
Copy Markdown

Move the "Copy to Clipboard (as TSV)" action out of the export dropdown menu and surface it as a dedicated Copy button in the statement execution bar, alongside the Export dropdown.

Move the "Copy to Clipboard (as TSV)" action out of the export
dropdown menu and surface it as a dedicated Copy button in the
statement execution bar, alongside the Export dropdown.

Always render the button (disabled when the result has no rows)
so the toolbar layout stays stable across executions, avoiding
layout shift when results are empty vs. non-empty.

@raymondtieu raymondtieu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract the copyTSVButton out of the dropdown component so it sits with the other sibling toolbar buttons?
Perhaps if that effort is too high or duplicates the button handlers/dependencies, can you rename the ResultExportDropdown to something like ResultExportActions since we're always showing the copy to clipboard button now?

@raymondtieu raymondtieu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm other than the 1 comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants