-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix(web): clarify terminal sidebar grouping #7967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maria-rcks
merged 5 commits into
pingdotgg:main
from
StiensWout:t3code/fix-terminal-group-spacing
Aug 24, 2026
+98
−70
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8079282
fix(web): space grouped terminal rows
StiensWout 884c2ca
fix(web): match terminal sidebar rows to panel tabs
StiensWout 471ce80
fix(web): clarify terminal group layouts
StiensWout b75ecb4
refactor(web): share panel tab close control
StiensWout 269eba5
fix(web): restore terminal close affordances
StiensWout File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { X } from "lucide-react"; | ||
| import type { ReactNode } from "react"; | ||
| import { Tooltip, TooltipPopup, TooltipTrigger } from "~/components/ui/tooltip"; | ||
|
|
||
| interface PanelTabCloseButtonProps { | ||
| children: ReactNode; | ||
| label: string; | ||
| onClick: () => void; | ||
| tooltip?: string; | ||
| } | ||
|
|
||
| /** Inside a `group/tab` row, swaps the tab identity for its close action on hover or focus. */ | ||
| export function PanelTabCloseButton({ | ||
| children, | ||
| label, | ||
| onClick, | ||
| tooltip, | ||
| }: PanelTabCloseButtonProps) { | ||
| const button = ( | ||
| <button | ||
| type="button" | ||
| className="cursor-pointer group/close relative flex size-4 shrink-0 items-center justify-center rounded-sm hover:bg-muted" | ||
| aria-label={label} | ||
| onClick={onClick} | ||
| > | ||
| <span className="relative flex size-3 items-center justify-center group-hover/tab:hidden group-focus-visible/close:hidden"> | ||
| {children} | ||
| </span> | ||
| <X className="hidden size-3 group-hover/tab:block group-focus-visible/close:block" /> | ||
| </button> | ||
| ); | ||
|
|
||
| if (!tooltip) return button; | ||
|
|
||
| return ( | ||
| <Tooltip> | ||
| <TooltipTrigger render={button} /> | ||
| <TooltipPopup>{tooltip}</TooltipPopup> | ||
| </Tooltip> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.