Skip to content

fix(web): align terminal sidebar tabs with right panel - #7967

Open
StiensWout wants to merge 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/fix-terminal-group-spacing
Open

fix(web): align terminal sidebar tabs with right panel#7967
StiensWout wants to merge 2 commits into
pingdotgg:mainfrom
StiensWout:t3code/fix-terminal-group-spacing

Conversation

@StiensWout

@StiensWout StiensWout commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Terminal rows in the drawer used a separate tree treatment from tabs in the right panel, so their hover and close interactions felt inconsistent.

This aligns terminal rows with the right-panel tab styling: the same 24px height, active and hover backgrounds, and terminal-icon-to-close transition. Group headers, spacing between groups, and the 2px gap within each group stay unchanged.

Before

Terminal sidebar before

After

Terminal sidebar after, with Terminal 1 hovered

Verification

  • pnpm exec vp fmt --check apps/web/src/components/ThreadTerminalDrawer.tsx
  • pnpm exec vp lint apps/web/src/components/ThreadTerminalDrawer.tsx
  • pnpm --filter @t3tools/web typecheck
  • pnpm exec vp test run apps/web/src/components/ThreadTerminalDrawer.test.ts
  • Playwright: inactive-row background changes on hover, terminal icon swaps to close, no duplicate IDs, and no horizontal overflow at 390px

Made with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Low Risk
Visual-only tab styling in the terminal sidebar; no session, close-confirm, or data-path changes.

Overview
Makes terminal drawer sidebar rows match right-panel tab chrome: 24px height, the same active/hover backgrounds, and the icon-to-close swap on hover/focus.

Drops the tree indent and hover-only close popover. Close is a dedicated control next to the label; group headers and spacing are unchanged.

Reviewed by Cursor Bugbot for commit 1da0e0e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Restyle terminal sidebar tabs in ThreadTerminalDrawer to match right panel

  • Replaces the conditional Popover-based close control with a fixed leading close button that is always visible, regardless of terminal count
  • Splits each terminal row into a close button and a separate activation button for the label, so clicking the label switches the active terminal
  • Updates row layout and hover/active styling: fixed height, text-xs, rounded-md, and removal of the tree-like indent guides tied to showGroupHeaders
  • Standardizes the terminal label fallback to capitalized "Terminal" for both display text and the close button aria-label
  • Risk: removal of the Popover tooltip and the showGroupHeaders left-border cue changes the visual affordances reviewers may be used to in ThreadTerminalDrawer.tsx

Macroscope summarized 1da0e0e.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 058c943f-18ab-422a-a018-7ef592354d1c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 23, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@StiensWout
StiensWout force-pushed the t3code/fix-terminal-group-spacing branch from 32515bc to 1da0e0e Compare August 23, 2026 09:09
@StiensWout StiensWout changed the title fix(web): space grouped terminal rows fix(web): align terminal sidebar tabs with right panel Aug 23, 2026
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant