[mickvdv]

Requested by Mick

What changed and why

When the meeting notes cannot be generated (the Claude CLI signed out, a timeout, an unreachable OpenAI-compatible endpoint), the job still finishes with its transcript and the only sign is the notification "Transcript Saved". That reads like success: with the CLI signed out, every meeting ends that way, and it can take weeks to notice. This announces the failure, with the reason, behind a setting that is on by default.

 Settings → Output
   Meeting Notes
     …
     Use AI title for filenames
+    Notify when meeting notes fail          on by default

Change

• PipelineJob.protocolFailure: the provider's error message when generation failed, nil otherwise and for snapshots written before it existed. Set in the existing catch in generateProtocol (recordProtocolFailure), next to the warning it already adds. The message is the content-free one that catch already logs at .public.
• PipelineQueue.doneNotification(for:announceNotesFailure:) picks the done notification: "Meeting Notes Ready" or "Transcript Saved" as before, or "Meeting Notes Failed" with "<title>": <reason>. The transcript is saved., time-sensitive. A reason that mentions login or authentication gets "Run claude in Terminal and sign in with /login." PipelineController.configureCallbacks calls it instead of choosing the title itself.
• AppSettings.notifyOnMeetingNotesFailure, persisted under notifyOnMeetingNotesFailure, default on. Off gives the old "Transcript Saved".
• Docs: docs/architecture/pipeline.md ("Protocol generation"), the README settings table, and the OutputSettingsView row in docs/architecture-macos.md.

Nothing changes for a job whose notes were generated or not asked for (provider None), and the job still ends .done.

Tests

• Reverted, or line set to a constant: PipelineQueue+Stages.swift:1097, recordProtocolFailure(id: jobID, reason: error.localizedDescription) removed
• Test that went red: WorkflowIntegrationTests.testWorkflowProtocolGenerationFailureRecordsTheReason
• Reverted, or line set to a constant: PipelineController.swift:387, announceNotesFailure: settings.notifyOnMeetingNotesFailure set to settings.notifyOnMeetingNotesFailure || true (a plain true does not compile: the capture becomes unused)
• Test that went red: AppStateTests.testConfigureCallbacksFailedNotesWithTheSettingOffFireTranscriptSaved (the setting off, the non-default value)
• Not checked: the notification on screen with Focus on; the text was checked by test only.

Also: MeetingNotesFailureNotificationTests (7 tests: default on, persistence, toggle wiring via A11yID.notifyOnMeetingNotesFailureToggle, and the ready, failed, login-hint and setting-off texts), and AppStateTests.testConfigureCallbacksFailedNotesFireTheFailedNotification.

AI assistance

• Written with: Claude (Anthropic), via Claude Code
• Reviewed or simplified with: the same

Checklist

• Rebased on main, no merge commits, since a merge commit pulls commits that are
  already on main into this branch and the review reads it commit by commit:
  git fetch https://github.com/pasrom/meeting-transcriber main && git rebase FETCH_HEAD
  (the URL spelled out because in a fork clone origin is your fork)
• ./scripts/lint.sh is clean, and ./scripts/lint.sh --analyze too (CI runs both)
• Tests pass: cd app/MeetingTranscriber && swift test
  (MenuBarIconSnapshotTests compare pixels and depend on the macOS version, so CI
  skips them; if only they fail, add --skip MenuBarIconSnapshotTests and tick this)
• Conventional Commits, one logical change per commit