[mickvdv]

Requested by Mick

What changed and why

Builds on #970 (retry meeting notes), which builds on #969; review the last commit, feat(app): generate meeting notes from saved transcripts. It reuses #970's MeetingNotesActions and DebugRPCServer+MeetingNotes.swift, so on its own it would conflict with it.

A retry needs the job, and the job is gone for a meeting from before the app kept failed ones, or one that was dismissed. Its transcript is still in the notes folder. This makes notes for transcripts the user picks, several at once, and offers the same over /v1.

 Menu bar
   Process Audio/Video Files...           ⌘P
+  Generate Meeting Notes from Transcript...

Change

• PipelineQueue.enqueueNotes(fromTranscripts:) queues one job per .txt, in order, with PipelineJob.generatesNotesOnly, transcriptPath and namingSlug set to the file and its name, and meetingStartTime from a leading yyyyMMdd_HHmm, so the prompt gets the meeting date. A transcript with a .md of its name next to it is left out (notesExist), as is one that is not a .txt or cannot be read (unreadable).
• runPipeline sends such a job to generateNotesOnly, right after the protocol-only resume and ahead of the engine guard, so it never transcribes, also after a relaunch. It checks again before generating: notes written, or the transcript gone, while the job waited end it in an error, never in an overwrite or a full run.
• The picked file is the user's, not a run's output, so these jobs keep the raw transcript and never rename by the AI title, whatever the settings say.
• PipelineController.generateNotes(fromTranscripts:) (new PipelineController+MeetingNotes.swift) refuses while the provider is None, since the jobs would end without notes, and names skipped files in a notification. settings and notifier on PipelineController went from private to internal for it.
• Menu: Generate Meeting Notes from Transcript... (A11yID.generateNotesFromTranscriptButton), an NSOpenPanel for plain text with multiple selection, starting in the output folder.
• /v1: POST /v1/jobs/notes/generate with {"paths": [...]}: 200 with jobIDs, notesExist and unreadable, 400 without paths, 409 while the provider is None.
• Docs: docs/automation-api.md, docs/architecture/pipeline.md, docs/architecture-macos.md, README features.

Tests

• Reverted, or line set to a constant: PipelineQueue+Stages.swift:230, job.generatesNotesOnly == true set to == false
• Test that went red: NotesFromTranscriptTests.testEachTranscriptGetsItsNotesWithoutTranscribing
• Reverted, or line set to a constant: PipelineQueue+MeetingNotes.swift:141, job.generatesNotesOnly = true set to nil
• Test that went red: NotesFromTranscriptTests.testEachTranscriptGetsItsNotesWithoutTranscribing
• Reverted, or line set to a constant: PipelineQueue+MeetingNotes.swift:137, saveRawTranscriptSeparately: true, useAITitleForFilenames: false set to nil, nil
• Test that went red: NotesFromTranscriptTests.testThePickedTranscriptIsNeitherRemovedNorRenamed (queue with the other two values)
• Reverted, or line set to a constant: PipelineController+MeetingNotes.swift:16, != .none set to != .openAICompatible
• Test that went red: NotesFromTranscriptTests.testWithoutANotesProviderNothingIsQueuedAndTheUserIsTold
• Reverted, or line set to a constant: AppState+RPC.swift:250, the generate: line removed
• Test that went red: NotesFromTranscriptTests.testTheAppWiresTheV1GenerateToItsController
• Reverted, or line set to a constant: MenuBarView.swift:211, onGenerateNotesFromTranscripts() set to onProcessFiles()
• Test that went red: NotesFromTranscriptTests.testTheMenuItemAsksForTranscripts
• Reverted, or line set to a constant: DebugRPCServer+MeetingNotes.swift:55, the generateMeetingNotesPath match changed to a path that never occurs
• Test that went red: NotesFromTranscriptTests.testV1GenerateAnswersWithWhatWasQueuedAndLeftOut
• Not checked: MeetingTranscriberApp.swift:210 (onGenerateNotesFromTranscripts: generateNotesFromTranscripts) and the NSOpenPanel itself, which the tests cannot reach (manual QA per docs/architecture/gui-testing.md; tried by hand in a local build). The App Store build: not tried; under the sandbox a picked file grants access to that file, and I did not measure whether writing the .md beside a transcript outside the output folder is allowed there.

Also: notes written while the job waited are not overwritten, a waiting job still makes only notes after a relaunch, the stamp parsing, and the skipped-files notification.

AI assistance

• Written with: Claude (Anthropic), via Claude Code
• Reviewed or simplified with: the same

Checklist

• Rebased on main, no merge commits, since a merge commit pulls commits that are
  already on main into this branch and the review reads it commit by commit:
  git fetch https://github.com/pasrom/meeting-transcriber main && git rebase FETCH_HEAD
  (the URL spelled out because in a fork clone origin is your fork)
• ./scripts/lint.sh is clean, and ./scripts/lint.sh --analyze too (CI runs both)
• Tests pass: cd app/MeetingTranscriber && swift test
  (MenuBarIconSnapshotTests compare pixels and depend on the macOS version, so CI
  skips them; if only they fail, add --skip MenuBarIconSnapshotTests and tick this)
• Conventional Commits, one logical change per commit