Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pynintendoparental/device/_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ async def update(self, now: datetime | None = None):
await self._get_parental_control_setting(now)
self._update_applications()
self._hydrate_players_from_monthly_summary(self.last_month_summary)
self._hydrate_players_from_daily_summaries(self.daily_summaries)
for player in self.players:
player.update_from_daily_summary(self.daily_summaries, self.applications, now=now)
await self._execute_callbacks()
Expand Down Expand Up @@ -277,6 +278,16 @@ def _hydrate_players_from_monthly_summary(self, summary: dict) -> None:
self.players.add_player(Player.from_profile(profile))
self.players.get_player(player_id).month_summary = player.get("summary", {})

def _hydrate_players_from_daily_summaries(self, summaries: list) -> None:
"""Create Player objects for players missing from the monthly summary."""
for summary in summaries:
for player in summary.get("players", []):
profile = player.get("profile")
if not profile or not profile.get("playerId"):
continue
if profile["playerId"] not in self.players:
self.players.add_player(Player.from_profile(profile))

def get_date_summary(self, input_date: datetime | None = None) -> list:
"""Get the usage summary for a specific date.

Expand Down
32 changes: 32 additions & 0 deletions tests/test_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -1132,3 +1132,35 @@ async def test_update_default_now_uses_api_timezone(
else:
assert device.today_playing_time == 60
assert any(player.playing_time > 0 for player in device.players)


async def test_players_from_daily_summaries_without_monthly_summary(mock_api: Api):
"""Test players are created from the daily summaries when there is no monthly summary."""
mock_api.async_get_device_monthly_summaries.return_value = {"json": {"available": []}}
raw = await load_fixture("account_devices")
device = Device.from_device_response(raw["ownedDevices"][0], mock_api)

await device.update()

summaries = (await load_fixture("device_daily_summaries"))["dailySummaries"]
expected = {player["profile"]["playerId"] for summary in summaries for player in summary["players"]}
assert expected
assert {player.player_id for player in device.players} == expected
mock_api.async_get_device_monthly_summary.assert_not_called()


async def test_new_player_from_daily_summaries(device: Device, mock_api: Api):
"""Test a player missing from the monthly summary is added once."""
summaries = await load_fixture("device_daily_summaries")
newcomer = copy.deepcopy(summaries["dailySummaries"][0]["players"][0])
newcomer["profile"]["playerId"] = "new-player-id"
newcomer["profile"]["nickname"] = "Alex"
summaries["dailySummaries"][0]["players"].append(newcomer)
mock_api.async_get_device_daily_summaries.return_value = {"json": summaries}
count_before = len(device.players)

await device.update()
await device.update()

assert len(device.players) == count_before + 1
assert device.players.get_player("new-player-id").nickname == "Alex"