Skip to content

Create players from the daily summaries - #159

Open
theSiegs wants to merge 1 commit into
pantherale0:mainfrom
theSiegs:pr/players-from-daily-summaries
Open

theSiegs wants to merge 1 commit into
pantherale0:mainfrom
theSiegs:pr/players-from-daily-summaries

Conversation

@theSiegs

Copy link
Copy Markdown

Players are only created from the monthly summary, so a console with less than a month of data has no players at all, and a player added since the last monthly summary is missing until the next one. In Home Assistant this shows up as missing player sensors (home-assistant/core#182387).

  • Device.update() now also creates the players it finds in the daily summaries. Existing players are left alone, and the monthly summary still fills in month_summary when there is one.
  • Tests: a console without a monthly summary gets its players from the daily summaries, and a player missing from the monthly summary is added once.

Suggested label: bug

Put together with AI assistance; reviewed and tested on my own install.

Players were only created from the monthly summary, so a console with
less than a month of data had no players, and a player added since the
last monthly summary was missing until the next one. Players the daily
summaries know are now created as well; existing players are untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant