Repository navigation
Conversation
Players were only created from the monthly summary, so a console with less than a month of data had no players, and a player added since the last monthly summary was missing until the next one. Players the daily summaries know are now created as well; existing players are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players are only created from the monthly summary, so a console with less than a month of data has no players at all, and a player added since the last monthly summary is missing until the next one. In Home Assistant this shows up as missing player sensors (home-assistant/core#182387).
Device.update()now also creates the players it finds in the daily summaries. Existing players are left alone, and the monthly summary still fills inmonth_summarywhen there is one.Suggested label:
bugPut together with AI assistance; reviewed and tested on my own install.