Skip to content

refactor!: remove remaining non-idiomatic TryFrom<&String> trait impls #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danieleades wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor!: remove remaining non-idiomatic TryFrom<&String> trait impls #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions typify-impl/src/type_entry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,15 +880,6 @@ impl TypeEntry {
value.parse()
}
}
impl ::std::convert::TryFrom<&::std::string::String> for #type_name {
type Error = self::error::ConversionError;

fn try_from(value: &::std::string::String) ->
::std::result::Result<Self, self::error::ConversionError>
{
value.parse()
}
}
impl ::std::convert::TryFrom<::std::string::String> for #type_name {
type Error = self::error::ConversionError;

Expand Down Expand Up @@ -946,15 +937,6 @@ impl TypeEntry {
value.parse()
}
}
impl ::std::convert::TryFrom<&::std::string::String> for #type_name {
type Error = self::error::ConversionError;

fn try_from(value: &::std::string::String) ->
::std::result::Result<Self, self::error::ConversionError>
{
value.parse()
}
}
impl ::std::convert::TryFrom<::std::string::String> for #type_name {
type Error = self::error::ConversionError;

Expand Down Expand Up @@ -1654,15 +1636,6 @@ impl TypeEntry {
value.parse()
}
}
impl ::std::convert::TryFrom<&::std::string::String> for #type_name {
type Error = self::error::ConversionError;

fn try_from(value: &::std::string::String) ->
::std::result::Result<Self, self::error::ConversionError>
{
value.parse()
}
}
impl ::std::convert::TryFrom<::std::string::String> for #type_name {
type Error = self::error::ConversionError;

Expand Down
8 changes: 0 additions & 8 deletions typify-impl/tests/generator.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,6 @@ mod types {
value.parse()
}
}
impl ::std::convert::TryFrom<&::std::string::String> for StringEnum {
type Error = self::error::ConversionError;
fn try_from(
value: &::std::string::String,
) -> ::std::result::Result<Self, self::error::ConversionError> {
value.parse()
}
}
impl ::std::convert::TryFrom<::std::string::String> for StringEnum {
type Error = self::error::ConversionError;
fn try_from(
Expand Down
Loading