refactor!: remove remaining non-idiomatic TryFrom<&String> trait impls#1040
Open
danieleades wants to merge 1 commit into
Open
refactor!: remove remaining non-idiomatic TryFrom<&String> trait impls#1040danieleades wants to merge 1 commit into
danieleades wants to merge 1 commit into
Conversation
oxidecomputer#946 removed the TryFrom<&String> impl generated for newtypes that proxy an inner type's FromStr, but three other emission sites still produced the same non-idiomatic impl: simple string enums, untagged newtype enums with FromStr conversion, and string-constrained newtypes. Remove them all; TryFrom<&str> covers callers via deref coercion, and TryFrom<String> remains for owned values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#946 removed the non-idiomatic
TryFrom<&String>impl at one emission site (newtypes proxying an inner type'sFromStr), but three other sites still generate the same impl:FromStrconversionThis removes all three, completing #946.
TryFrom<&str>covers&Stringcallers via deref coercion, andTryFrom<String>remains for owned values. −7,143 lines across the test goldens (835 impl blocks).Breaking for any caller spelling
T::try_from(&string)where inference relied on the&Stringimpl — same trade-off as accepted in #946.