feat(web-ongoing-operations): fix translate keys#23010
Open
louisbensiovh wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
universe-web-cloud
translation required
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the i18n translation key pattern used by the “string argument” update UI in web-ongoing-operations, aligning labels with the domain_operations_update_* namespace (ticket DCE-218).
Changes:
- Update
UpdateStringComponentto usedomain_operations_update_${argumentKey}instead ofdomain_operations_update_key_${argumentKey}. - Rename a subset of French (
fr_FR) translation keys to the new pattern.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/manager/apps/web-ongoing-operations/src/components/Update/Content/Update.String.component.tsx | Switches the translation key format used for string-argument field labels. |
| packages/manager/apps/web-ongoing-operations/public/translations/dashboard/Messages_fr_FR.json | Renames several domain_operations_update_key_* entries to domain_operations_update_* in French translations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <FormField className="w-1/4" invalid={error != null && error.length > 0}> | ||
| <FormFieldLabel> | ||
| {t(`domain_operations_update_key_${argumentKey}`)} | ||
| {t(`domain_operations_update_${argumentKey}`)} |
Contributor
Author
There was a problem hiding this comment.
Using translator fast pass to correct this
louisbensiovh
force-pushed
the
fix/DCE-218
branch
from
419c0db to
77c65bf
Compare
| <FormField className="w-1/4" invalid={error != null && error.length > 0}> | ||
| <FormFieldLabel> | ||
| {t(`domain_operations_update_key_${argumentKey}`)} | ||
| {t(`domain_operations_update_${argumentKey}`)} |
ref: #DCE-218 Signed-off-by: Louis BENSI <louis.bensi@corp.ovh.com>
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
louisbensiovh
force-pushed
the
fix/DCE-218
branch
from
0bc4007 to
4852fbc
Compare
| <FormField className="w-1/4" invalid={error != null && error.length > 0}> | ||
| <FormFieldLabel> | ||
| {t(`domain_operations_update_key_${argumentKey}`)} | ||
| {t(`domain_operations_update_${argumentKey}`)} |
github-actions
Bot
added
the
dependencies
| <FormField className="w-1/4" invalid={error != null && error.length > 0}> | ||
| <FormFieldLabel> | ||
| {t(`domain_operations_update_key_${argumentKey}`)} | ||
| {t(`domain_operations_update_${argumentKey}`)} |
Fresh pnpm installs resolved the transitive @types/react to 19.2.17 while the app runs React 18.2.0, producing 94 TS2786/TS2345 errors (React 18/19 type mismatch). Pinning @types/react and @types/react-dom in devDependencies lets manager-pm's critical-deps normalization keep them on v18, like every other pnpm-managed app. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
louisbensiovh
force-pushed
the
fix/DCE-218
branch
from
6dfec71 to
80561ec
Compare
github-actions
Bot
removed
the
dependencies
| <FormField className="w-1/4" invalid={error != null && error.length > 0}> | ||
| <FormFieldLabel> | ||
| {t(`domain_operations_update_key_${argumentKey}`)} | ||
| {t(`domain_operations_update_${argumentKey}`)} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the translate keys
Ticket Reference: #DCE-218