exec-server: centralize client RPC spans#31689
Closed
anp-oai wants to merge 3 commits into
Closed
Conversation
This was referenced Jul 9, 2026
anp-oai
force-pushed
the
codex/exec-server-rpc-span-fields
branch
from
3b6a3e7 to
c671b06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
environment/infouses the timed client-call path, which bypassed the existing RPC client span and left one admitted request path without the basic trace boundary.What
Move the existing client RPC instrumentation from the normal and cleanup wrappers into their shared
call_innerpath. Normal, timed, and cleanup requests now receive exactly one client span; admission failures remain outside because they do not send an RPC request.Serialize exec-server tracing tests that rebuild tracing's process-global callsite-interest cache so concurrent thread-local subscribers cannot invalidate one another's span callsites.
Validation
just test -p codex-exec-server rpc_client_(5 passed)just test -p codex-exec-server --lib(172 passed)just test -p codex-exec-serveron the completed stack (306 passed, 2 skipped)Stack
2 of 3: