Skip to content

Revert "LiveText: pumped generator follow-up (#20216)" - #20472

Merged
seanbudd merged 1 commit into
masterfrom
revert-20216-live-text-skip-beep
Jul 9, 2026
Merged

Revert "LiveText: pumped generator follow-up (#20216)"#20472
seanbudd merged 1 commit into
masterfrom
revert-20216-live-text-skip-beep

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 9, 2026

Copy link
Copy Markdown
Member

This reverts commit 9fe7dde.

Reverts PR

Reverts #20216

Issues fixed

N/A

Issues reopened

N/A

Reason for revert

Introduced hidden config params

Can this PR be reimplemented? If so, what is required for the next attempt

#20216 (comment)

@seanbudd
seanbudd requested review from a team as code owners July 9, 2026 07:34
@seanbudd
seanbudd merged commit 9294255 into master Jul 9, 2026
9 of 10 checks passed
@seanbudd
seanbudd deleted the revert-20216-live-text-skip-beep branch July 9, 2026 07:34
@github-actions github-actions Bot added this to the 2026.3 milestone Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the changes introduced by #20216 (commit 9fe7dde9ab1b173d3c03f001bb2704121ac8ad7f) to remove the “hidden config params” it added for terminal live-text handling, restoring the prior behavior and documentation/UI state.

Changes:

  • Removes the “Beep for skipped lines” advanced setting from the UI and User Guide.
  • Removes hidden terminal config keys (maxNewLines, newLinesBatchSize, beepForSkippedLines) from the config spec and the corresponding runtime usage.
  • Restores terminal live-text reporting to use a fixed maximum line cap and a fixed yield cadence (rather than configurable hidden parameters).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
user_docs/en/userGuide.md Removes the documented “Beep for skipped lines” advanced setting section.
user_docs/en/changes.md Updates release notes entry to remove the #20216 reference (revert context).
source/NVDAObjects/behaviors.py Removes runtime dependence on the hidden terminal config params and returns to a fixed cap/yield approach.
source/gui/settingsDialogs.py Removes the “Beep for skipped lines” checkbox wiring from Advanced Settings.
source/config/configSpec.py Removes the hidden [terminals] config keys introduced by #20216.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants