Revert "LiveText: pumped generator follow-up (#20216)" - #20472
Merged
Conversation
This reverts commit 9fe7dde.
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the changes introduced by #20216 (commit 9fe7dde9ab1b173d3c03f001bb2704121ac8ad7f) to remove the “hidden config params” it added for terminal live-text handling, restoring the prior behavior and documentation/UI state.
Changes:
- Removes the “Beep for skipped lines” advanced setting from the UI and User Guide.
- Removes hidden terminal config keys (
maxNewLines,newLinesBatchSize,beepForSkippedLines) from the config spec and the corresponding runtime usage. - Restores terminal live-text reporting to use a fixed maximum line cap and a fixed yield cadence (rather than configurable hidden parameters).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/userGuide.md | Removes the documented “Beep for skipped lines” advanced setting section. |
| user_docs/en/changes.md | Updates release notes entry to remove the #20216 reference (revert context). |
| source/NVDAObjects/behaviors.py | Removes runtime dependence on the hidden terminal config params and returns to a fixed cap/yield approach. |
| source/gui/settingsDialogs.py | Removes the “Beep for skipped lines” checkbox wiring from Advanced Settings. |
| source/config/configSpec.py | Removes the hidden [terminals] config keys introduced by #20216. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9fe7dde.
Reverts PR
Reverts #20216
Issues fixed
N/A
Issues reopened
N/A
Reason for revert
Introduced hidden config params
Can this PR be reimplemented? If so, what is required for the next attempt
#20216 (comment)