LiveText: pumped generator follow-up - #20216
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new “Beep for skipped lines” terminal setting and related terminal flood-handling controls, while updating release notes for the live-region freeze fix.
Changes:
- Documented and surfaced a new Advanced setting: “Beep for skipped lines”.
- Added config options to cap/batch reported terminal lines and to configure the skipped-lines beep.
- Updated changelog entry to include additional issue/credit references.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/userGuide.md | Documents the new “Beep for skipped lines” Advanced setting. |
| user_docs/en/changes.md | Updates the bug-fix entry with additional references/credits. |
| source/gui/settingsDialogs.py | Adds the Advanced Settings checkbox, default handling, and persistence. |
| source/config/configSpec.py | Introduces new [terminals] tuning options (limits, batching, beep params). |
| source/NVDAObjects/behaviors.py | Implements line dropping, batching, and optional beep when lines are skipped. |
… the new LiveText speech generator
8ac79a8 to
f003e22
Compare
|
@codeofdusk I like this, fully agree it should be done. |
|
Is this something you intend to continue to work on? |
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
| Warning: with this option enabled, typed characters that do not appear onscreen, such as passwords, will not be suppressed. | ||
| In untrusted environments, you may temporarily disable [speak typed characters](#KeyboardSettingsSpeakTypedCharacters) and [speak typed words](#KeyboardSettingsSpeakTypedWords) when entering passwords. | ||
|
|
||
| ##### Beep for skipped lines {#AdvancedSettingsBeepForSkippedLines} |
There was a problem hiding this comment.
We usually no longer put the name of the panel in the anchor. This way, if the setting is moved in the future, the anchor remains valid and does not become inconsistent with its new location.
| ##### Beep for skipped lines {#AdvancedSettingsBeepForSkippedLines} | |
| ##### Beep for skipped lines {#TerminalBeepForSkippedLines} |
|
@seanbudd I am surprised to see that you have accepted 3 new hidden config parameters, while you have recently written that you wouldn't accept new ones. Did I miss something? Also, the anchor should ideally be fixed to avoid the panel's name; if a subsequent PR is done, this can be included in it. |
|
@CyrilleB79 - my bad, I assumed the review comment was addressed correctly and missed this on the diff review. Will revert this for now. |
This reverts commit 9fe7dde. ### Reverts PR Reverts #20216 ### Issues fixed N/A ### Issues reopened N/A ### Reason for revert Introduced hidden config params ### Can this PR be reimplemented? If so, what is required for the next attempt #20216 (comment)
|
Reverted via #20472, please make sure the next implementation doesn't introduce hidden config params as requested. Fixing up the user guide anchor would be great too |
#20177, supersedes #20216. Summary of the issue: After #20177: It is impossible to tell whether lines have been skipped during large text floods; Copyright and attributions were outdated or missing. Description of how this pull request fixes the issue: This PR: Updates copyright and attribution; Adds a "beep for skipped lines" option to terminal programs settings.
Link to issue number:
#20177
Summary of the issue:
After #20177:
Description of how this pull request fixes the issue:
This PR:
Testing strategy:
Verified that all settings and the beep work as expected. Alpha testing.
Known issues with pull request:
None known
Code Review Checklist: