Skip to content

feat: add more patterns to unnecessary files hints#3050

Open
gameroman wants to merge 14 commits into
npmx-dev:mainfrom
gameroman:unnecessary-files-hints
Open

feat: add more patterns to unnecessary files hints#3050
gameroman wants to merge 14 commits into
npmx-dev:mainfrom
gameroman:unnecessary-files-hints

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

None

🧭 Context

Some more patterns for files that are unnecessarily published to npmx

📚 Description

Add more patterns to unnecessary files hints

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 15, 2026 5:57pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 15, 2026 5:57pm
npmx-lunaria Ignored Ignored Jul 15, 2026 5:57pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The package content heuristics now recognise additional configuration files, changelog variants, test-file suffixes, and example/spec directories. Unit tests cover the new detections and legal-file exclusions.

Changes

Package content hint detection

Layer / File(s) Summary
Expand unnecessary content detection
app/utils/package-content-hints.ts, test/unit/app/utils/package-content-hints.spec.ts
Additional configuration and CI files, changelog variants, spec/example directories, and .test/.spec filename patterns are flagged and covered by unit tests. Legal-file exclusions are tested separately.

Possibly related PRs

  • npmx-dev/npmx.dev#2714: Extends the same package content heuristics consumed by file and directory listing components.
  • npmx-dev/npmx.dev#3045: Updates the same heuristics and unit tests with overlapping filename and directory cases.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: expanding patterns for unnecessary file hints.
Description check ✅ Passed The description is directly related to the changeset and matches the stated objective.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/utils/package-content-hints.ts`:
- Around line 68-69: The test/spec filename regex in
app/utils/package-content-hints.ts lines 68-69 must require a separator before
“test” or “spec” so latest.js is not matched; update the regex while preserving
valid test/spec filenames. Add a regression case for latest.js in
test/unit/app/utils/package-content-hints.spec.ts lines 38-44 and assert it is
not identified as a test/spec file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f8626559-07fd-4dd4-aa08-25db64a8886e

📥 Commits

Reviewing files that changed from the base of the PR and between 53acd4a and 88c71ce.

📒 Files selected for processing (2)
  • app/utils/package-content-hints.ts
  • test/unit/app/utils/package-content-hints.spec.ts

Comment thread app/utils/package-content-hints.ts Outdated
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman gameroman requested a review from a team July 15, 2026 18:15
@gameroman gameroman added the needs review This PR is waiting for a review from a maintainer label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review This PR is waiting for a review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant