Skip to content

feat: add more patterns to unnecessary files hints#3045

Closed
gameroman wants to merge 4 commits into
mainfrom
roman/unnecessary-files-hints
Closed

feat: add more patterns to unnecessary files hints#3045
gameroman wants to merge 4 commits into
mainfrom
roman/unnecessary-files-hints

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

None

🧭 Context

Some more patterns for files that are unnecessarily published to npmx

📚 Description

Add more patterns to unnecessary files hints

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 15, 2026 5:01pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 15, 2026 5:01pm
npmx-lunaria Ignored Ignored Jul 15, 2026 5:01pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81a77cae-18c4-465b-9358-ea18cf0d3df0

📥 Commits

Reviewing files that changed from the base of the PR and between a3dafe7 and 88c71ce.

📒 Files selected for processing (2)
  • app/utils/package-content-hints.ts
  • test/unit/app/utils/package-content-hints.spec.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • test/unit/app/utils/package-content-hints.spec.ts
  • app/utils/package-content-hints.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved detection of potentially unnecessary package content.
    • Added recognition for additional editor, configuration, CI, changelog, test, specification and example files or directories.
  • Tests
    • Expanded coverage to verify the newly recognised filenames, patterns and directories.

Walkthrough

Changes

Package content hints

Layer / File(s) Summary
Expand unnecessary-content heuristics
app/utils/package-content-hints.ts, test/unit/app/utils/package-content-hints.spec.ts
Additional editor, CI, changelog, specification, example, and test/spec filename cases are flagged and covered by unit tests.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: expanding unnecessary-file hint patterns.
Description check ✅ Passed The description matches the changes by stating additional patterns were added to unnecessary files hints.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch roman/unnecessary-files-hints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman
gameroman force-pushed the roman/unnecessary-files-hints branch from 68e75e2 to 88c71ce Compare July 15, 2026 16:58
@gameroman

Copy link
Copy Markdown
Member Author

Reopened as #3050 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants