chore: Update noir_stdlib version to match that of nargo - #12377
Conversation
|
I think whenever we release a new Noir version, the version in the Nargo.toml for the stdlib should be bumped too... maybe this should be automated? But I don't know how... |
|
Yes, this should be automated with release-please |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 7f7b9cb | Previous: 709b64e | Ratio |
|---|---|---|---|
rollup-block-root |
0.003 s |
0.002 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 7f7b9cb | Previous: 709b64e | Ratio |
|---|---|---|---|
rollup-block-root |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 7f7b9cb | Previous: 709b64e | Ratio |
|---|---|---|---|
test_report_noir-lang_noir-bignum_ |
135 s |
106 s |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 7f7b9cb | Previous: 709b64e | Ratio |
|---|---|---|---|
rollup-block-root |
2.02 s |
1.5 s |
1.35 |
rollup-tx-merge |
1.872 s |
1.514 s |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Elaboration Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 7f7b9cb | Previous: 709b64e | Ratio |
|---|---|---|---|
rollup-block-root |
1.56 s |
1.17 s |
1.33 |
rollup-tx-merge |
1.506 s |
1.204 s |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 7f7b9cb | Previous: 709b64e | Ratio |
|---|---|---|---|
rollup-block-root |
1.92 s |
1.45 s |
1.32 |
rollup-tx-merge |
1.812 s |
1.462 s |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
noir_stdlib version to beta.15noir_stdlib version to match that of nargo
noir_stdlib version to match that of nargonoir_stdlib version to match that of nargo
Problem Resolved
I wanted to update Lampe to use the latest release of
nargo, which is b4236c1 so I opened reilabs/lampe#254(I had to do this to get the latest
noir-schnorrcompiled, because the Noir compiler embedded in Lampe expects theis_infinitefield for anEmbeddedCurvePoint, which the library no longer has, as it is built against a newer version of the stdlib).Lampe contains a mirror of our
noir_stdlib, which was at versionstd-1.0.0-beta.14before, and this is the version which appears in Lean files when referring to various types in the library.There are quite a few changes in our stdlib since their latest mirror:
EmbeddedCurvePoint::is_infinitehas been removed: this needs an update in the proofs Lampe has for the stdliblampeSo these are breaking changes, and yet our stdlib version hasn't been changed.
Summary of Changes
Bumps the stdlib version to match the current beta.20 of Noir / nargo, and updates
release-pleaseto keep them in sync.This doesn't affect the existing release, but perhaps by the time Lampe picks it up, we'll have a newer one.
User Documentation
Check one:
PR Checklist
cargo fmton default settings.