Add Hungarian localization strings to hu.yml#343
Conversation
📝 WalkthroughWalkthroughAdds a Hungarian localization catalog with translated UI, status, error, connectivity, messaging, storage, and diagnostic strings, including formatted placeholders and pluralization entries. ChangesHungarian localization
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locale/hu.yml`:
- Line 55: Update the Hungarian translations in the grouped role string at line
55 to use the established tracker terminology from line 108: replace the
standalone “Tracker” and “TAK Tracker” translations with “Követő” and “TAK
követő”, respectively, while preserving all other translations.
- Around line 45-47: Update the Hungarian translations for “Node Search” and
“Node Options” in locale/hu.yml to use the established “csomópont” terminology
consistently, matching the existing usage elsewhere in the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| Node Search: Node keresése | ||
| Packet Statistics: Csomagstatisztika | ||
| Node Options: Node beállítások |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== locale/hu.yml relevant lines =="
nl -ba locale/hu.yml | sed -n '35,55p'
echo
echo "== occurrences of Node / csomópont / node in locale/hu.yml =="
rg -n 'Node|csomópont|node' locale/hu.yml || true
echo
echo "== other Hungarian locale files, if any =="
fd -a 'hu*.yml' locale || true
echo
echo "== cross-locale usage of the Node Search / Node Options keys =="
rg -n '^ (Node Search|Node Options|Packet Statistics):' locale -g '*.yml' || trueRepository: meshtastic/device-ui
Length of output: 233
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== locale/hu.yml relevant lines =="
awk 'NR>=35 && NR<=55 {printf "%4d %s\n", NR, $0}' locale/hu.yml
echo
echo "== occurrences of Node / csomópont / node in locale/hu.yml =="
rg -n 'Node|csomópont|node' locale/hu.yml || true
echo
echo "== keys containing Node in all locale files =="
rg -n '^ (Node Search|Node Options|Packet Statistics):' locale -g '*.yml' || true
echo
echo "== other Hungarian translation choices for comparable labels =="
rg -n '^ .*: .*csomópont|^ .*: .*Node' locale/hu.yml || trueRepository: meshtastic/device-ui
Length of output: 5926
Use the Hungarian term for “node” consistently. Node Search and Node Options still use English Node, while the rest of locale/hu.yml already uses csomópont.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locale/hu.yml` around lines 45 - 47, Update the Hungarian translations for
“Node Search” and “Node Options” in locale/hu.yml to use the established
“csomópont” terminology consistently, matching the existing usage elsewhere in
the file.
| <unset>: <nincs beállítva> | ||
| Secondary Channels: Másodlagos csatornák | ||
| "LONG FAST\nLONG MODERATE\nLONG TURBO\nMEDIUM FAST\nMEDIUM SLOW\nSHORT FAST\nSHORT TURBO\nSHORT SLOW": "HOSSZÚ GYORS\nHOSSZÚ KÖZEPES\nHOSSZÚ TURBÓ\nKÖZEPES GYORS\nKÖZEPES LASSÚ\nRÖVID GYORS\nRÖVID TURBÓ\nRÖVID LASSÚ" | ||
| "Client\nClient Mute\nRouter\nRepeater\nTracker\nSensor\nTAK\nClient Hidden\nLost & Found\nTAK Tracker\nRouter Late": "Kliens\nNémított kliens\nRouter\nIsmétlő\nTracker\nÉrzékelő\nTAK\nRejtett kliens\nElveszett és megtalált\nTAK Tracker\nKésleltetett Router" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the Hungarian locale file and related tracker terminology.
git ls-files 'locale/*.yml' | sed -n '1,20p'
printf '\n--- hu.yml hits ---\n'
rg -n '"Tracker|Követő|TAK Tracker|TAK követő|Client Hidden|Router Late' locale/hu.yml locale/*.yml
printf '\n--- hu.yml around the cited lines ---\n'
sed -n '45,65p' locale/hu.yml
printf '\n--- hu.yml around line 108 ---\n'
sed -n '100,115p' locale/hu.ymlRepository: meshtastic/device-ui
Length of output: 8045
Keep tracker terminology consistent
locale/hu.yml:55 should use the same Hungarian wording as line 108 (Követő / TAK követő) so the same roles don’t appear differently across screens.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locale/hu.yml` at line 55, Update the Hungarian translations in the grouped
role string at line 55 to use the established tracker terminology from line 108:
replace the standalone “Tracker” and “TAK Tracker” translations with “Követő”
and “TAK követő”, respectively, while preserving all other translations.
|
|
|
@pisti87 Can you pls. resolve all open issues, thanks. |
Summary by CodeRabbit