Skip to content

Fixed false-positive Mobile Safari detection for AppleCoreMedia/1.0.0… #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ionut-slaveanu wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed false-positive Mobile Safari detection for AppleCoreMedia/1.0.0… #8369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1027ece
Fixed false-positive Mobile Safari detection for AppleCoreMedia/1.0.…
ionut-slaveanu Aug 18, 2026
8eb1c06
Apply suggestions from code review
ionut-slaveanu Aug 18, 2026
c0d260b
- fixed unit tests
ionut-slaveanu Aug 18, 2026
4a4ce97
- removed trailing spaces
ionut-slaveanu Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions Tests/Parser/Client/fixtures/library.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,3 +833,45 @@
type: library
name: nscurl
version: ""
-
user_agent: AppleCoreMedia/1.0.0.22F76 (iPad; U; CPU OS 18_5 like Mac OS X; en_us)
client:
type: library
name: Apple Core Media
version: ""
-
user_agent: AppleCoreMedia/1.0.0.9A405 (iPod; U; CPU OS 5_0_1 like Mac OS X; en_us)
client:
type: library
name: Apple Core Media
version: ""
-
user_agent: AppleCoreMedia/1.0.0.19H218 (iPod touch; U; CPU OS 15_7_2 like Mac OS X; en_us)
client:
type: library
name: Apple Core Media
version: ""
-
user_agent: AppleCoreMedia/1.0.0.18A347e (Macintosh; U; Intel Mac OS X 10_14; en_us)
client:
type: library
name: Apple Core Media
version: ""
-
user_agent: AppleCoreMedia/1.0.0.18G82 (iPhone; U; CPU OS 14_7_1 like Mac OS X; es_xl)
client:
type: library
name: Apple Core Media
version: ""
-
user_agent: AppleCoreMedia/1.0.0.15F80 (HomePod; U; CPU OS 11_4 like Mac OS X; fr_fr)
client:
type: library
name: Apple Core Media
version: ""
-
user_agent: AppleCoreMedia/1.0.0.17K449 (Apple TV; U; CPU OS 13_3 like Mac OS X; en_us)
client:
type: library
name: Apple Core Media
version: ""
2 changes: 1 addition & 1 deletion Tests/fixtures/smart_speaker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
platform: ""
client:
type: library
name: iOS Application
name: Apple Core Media
version: ""
device:
type: smart speaker
Expand Down
6 changes: 3 additions & 3 deletions Tests/fixtures/tv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@
platform: ARM
client:
type: library
name: iOS Application
name: Apple Core Media
version: ""
device:
type: tv
Expand Down Expand Up @@ -6601,7 +6601,7 @@
platform: ARM
client:
type: library
name: iOS Application
name: Apple Core Media
version: ""
device:
type: tv
Expand All @@ -6617,7 +6617,7 @@
platform: ARM
client:
type: library
name: iOS Application
name: Apple Core Media
version: ""
device:
type: tv
Expand Down
2 changes: 1 addition & 1 deletion Tests/fixtures/wearable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,7 +1274,7 @@
platform: ""
client:
type: library
name: iOS Application
name: Apple Core Media
version: ""
device:
type: wearable
Expand Down
4 changes: 2 additions & 2 deletions regexes/client/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3576,7 +3576,7 @@
version: '$1'
engine:
default: 'WebKit'
- regex: '(?!^AppleCoreMedia/1\.0\.0)(?:iPod|(?<!Apple TV; U; CPU )iPhone|iPad)'
- regex: '^(?!AppleCoreMedia).*?\b(?<!Apple-)(?:iPod|(?<!Apple TV; U; CPU )iPhone|iPad)'
name: 'Mobile Safari'
version: ''
engine:
Expand All @@ -3591,7 +3591,7 @@
version: '$1'
engine:
default: 'WebKit'
- regex: 'Macintosh'
- regex: '^(?!AppleCoreMedia).*?\bMacintosh'
name: 'Safari'
version: ''
engine:
Expand Down
4 changes: 2 additions & 2 deletions regexes/client/libraries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,8 +551,8 @@
# agent will default to this, always with 1.0.0 version.
# there was a time when (not even that long ago) apple didn't let you set
# a user agent so a ton of random applications still identify themselves this way.
- regex: 'AppleCoreMedia/1\.0\.0'
name: 'iOS Application'
- regex: 'AppleCoreMedia'
name: 'Apple Core Media'
version: ''

- regex: 'cpp-httplib(?:/(\d+[.\d]+))?'
Expand Down
Loading