Fixed false-positive Mobile Safari detection for AppleCoreMedia/1.0.0…

[ionut-slaveanu]

AppleCoreMedia/1.0.0.18G82 (iPhone; U; CPU OS 14_7_1 like Mac OS X; es_xl)

Description

Fix detection of AppleCoreMedia user agents that are incorrectly identified as Mobile Safari.

User agents such as:

• AppleCoreMedia/1.0.0.18G82 (iPhone; U; CPU OS 14_7_1 like Mac OS X; es_xl)

contain iPhone, causing them to match the Mobile Safari browser regex even though the user agent represents an iOS application using AppleCoreMedia/1.0.0 framewiork.

The

• AppleCoreMedia/1.0.0.18G82 (iPhone; U; CPU OS 14_7_1 like Mac OS X; es_xl)

user agent should match the following regex from regexes/client/libraries.yml:

• regex: 'AppleCoreMedia/1.0.0'
  name: 'iOS Application'
  version: ''

Instead, it currently matches the Mobile Safari regex from regexes/client/browsers.yml:

• regex: '(?!^AppleCoreMedia/1.0.0)(?:iPod|(?<!Apple TV; U; CPU )iPhone|iPad)'
  name: 'Mobile Safari'
  version: ''
  engine:

Expected behavior
AppleCoreMedia/1.0.0 (iPhone; ...) → iOS Application

Checklist

• [✔/✖/NA] I have understood, reviewed, and tested all AI outputs before use
• [✔/✖/NA] All AI instructions respect security, IP, and privacy rules

Review

• Functional review done
• Potential edge cases thought about (behaviour of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• New documentation added or existing documentation updated

[liviuconcioiu]

@ionut-slaveanu you need to move the test to /Tests/Parser/Client/fixtures/library.yml, since client is a library.

-
  user_agent: AppleCoreMedia/1.0.0.18G82 (iPhone; U; CPU OS 14_7_1 like Mac OS X; es_xl)
  client:
    type: library
    name: iOS Application
    version: ""

[ionut-slaveanu]

@ionut-slaveanu you need to move the test to /Tests/Parser/Client/fixtures/library.yml, since client is a library.

-
  user_agent: AppleCoreMedia/1.0.0.18G82 (iPhone; U; CPU OS 14_7_1 like Mac OS X; es_xl)
  client:
    type: library
    name: iOS Application
    version: ""

Done!

[liviuconcioiu]

I made some code suggestions that can be merged.

You need to also replace lines:

device-detector/regexes/client/libraries.yml

Lines 554 to 555 in 1a80bcf

	- regex: 'AppleCoreMedia/1\.0\.0'
	name: 'iOS Application'

with:

- regex: 'AppleCoreMedia'
  name: 'Apple Core Media'

Line:

device-detector/regexes/client/browsers.yml

Line 3594 in 1a80bcf

- regex: 'Macintosh'

with:

- regex: '^(?!AppleCoreMedia).*?\bMacintosh'

After you make the changes, run ./vendor/bin/phpunit and fix all tests.

[ionut-slaveanu]

I made some code suggestions that can be merged.

You need to also replace lines:

device-detector/regexes/client/libraries.yml

Lines 554 to 555 in 1a80bcf

	- regex: 'AppleCoreMedia/1\.0\.0'
	name: 'iOS Application'

with:

- regex: 'AppleCoreMedia'
  name: 'Apple Core Media'

Line:

device-detector/regexes/client/browsers.yml

Line 3594 in 1a80bcf

- regex: 'Macintosh'

with:

- regex: '^(?!AppleCoreMedia).*?\bMacintosh'

After you make the changes, run ./vendor/bin/phpunit and fix all tests.

Done!

[liviuconcioiu]

This should close #5869. AppleCoreMedia is used by other podcast apps too.