Repository navigation
Conversation
The admin order create model loaded Magento\Wishlist models through the object manager when it showed the customer's wish list in the sidebar, moved a quote item to a wish list, added a wish list item to the order or removed one. Sales' layouts also always placed the wish list sidebar section. Without module-wishlist, opening the order create page failed. Add Magento\Sales\Model\AdminOrder\WishlistProviderInterface, which loads a customer's wish list, a wish list by ID and a wish list item. Sales binds it to NullWishlistProvider; Magento_Wishlist binds it to Wishlist\Model\Sales\AdminOrder\WishlistProvider in its adminhtml di.xml. Create gets the provider as a new optional constructor argument. Without wish lists, getCustomerWishlist() returns false, moving an item to a wish list reports that the wish list can't be found, and wish list items in the request are ignored. The wish list sidebar section is now placed by Magento_Wishlist's layouts, after the shopping cart section as before, and the sales_order_create_load_block_sidebar_wishlist handle moves there. The Sidebar\Wishlist block class stays in Sales. With this, Magento_Sales' composer.json drops magento/module-wishlist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Sales\Model\AdminOrder\Createcreates Wishlist models through the object manager, and Sales' layouts always place the wish list sidebar section. Without Wishlist, the order create page fails. This finishes the Sales part after #287.Sales\Model\AdminOrder\WishlistProviderInterfacewith a null implementation. Wishlist binds the real one inadminhtml/di.xml, as Decouple the admin order-create items grid from Magento_Wishlist #287 does.Createuses it through a new optional constructor argument. Without wish lists,getCustomerWishlist()returnsfalseand wish list actions are skipped.composer.json.Related Pull Requests
#287, #395, #396, #397, #398, #400
Manual testing scenarios (*)
Contribution checklist (*)
🤖 Generated with Claude Code