Skip to content

Move the admin customer Wish List controllers and block into Magento_Wishlist - #395

Draft
pingiun wants to merge 2 commits into
mage-os:mainfrom
cresset-tools:customer-move-wishlist-tab
Draft

pingiun wants to merge 2 commits into
mage-os:mainfrom
cresset-tools:customer-move-wishlist-tab

Conversation

@pingiun

@pingiun pingiun commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Description (*)

Magento_Customer hosts the admin wish list tab's controllers and block. They only work on Wishlist models, so Customer requires magento/module-wishlist. Part of the series that makes Magento_Wishlist removable (#286, #287).

  • Move Index\Wishlist, Index\ViewWishlist, the Wishlist\Product\Composite\Wishlist configure/update actions, and the Edit\Tab\View\Wishlist block with its layout into Magento_Wishlist.
  • Add a Wishlist adminhtml/routes.xml that joins the customer route before="Magento_Customer", so the URLs don't change.
  • Drop the require from Customer's composer.json, and list the old class names in obsolete_classes.php.

Related Pull Requests

#396, #397, #398, #399, #400

Manual testing scenarios (*)

  1. In a customer's admin "Wish List" tab, filtering, deleting an item and configuring an item work as before.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

🤖 Generated with Claude Code

…Wishlist

Magento_Customer hosted the admin wishlist actions (customer/index/wishlist,
customer/index/viewWishlist and the
customer/wishlist_product_composite_wishlist configure/update actions), the
"customer view" wishlist grid block and its layout. All of them work on
Magento\Wishlist models, which made Magento_Wishlist a hard requirement of
Magento_Customer.

Move them into Magento_Wishlist, which already depends on Magento_Customer.
A Wishlist adminhtml routes.xml joins the existing `customer` admin route
before Magento_Customer, so every URL stays the same. The grid renderers
stay in Customer because the shopping cart tab uses them too, and they
don't reference Wishlist classes.

Customer's unit tests no longer use Wishlist classes, and its composer.json
drops magento/module-wishlist. The moved classes are listed in
obsolete_classes.php with their new names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant