feat: add shared catalog queries and screen recipe contracts - #11
Merged
Merged
Conversation
lidge-jun
marked this pull request as ready for review
September 22, 2026 10:20
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The six design catalogs cannot currently be queried through a common executable contract, and cross-links do not describe how to assemble a screen. This adds a pure classic-script TypeScript core for deterministic bilingual search, version-bound pagination and complete guide/code views, plus three authored screen recipes with explicit alternatives, constraints and source attribution.
The browser and Node adapter use the same generated core and canonical metadata. Existing Finder ranking, catalog entries and approved images remain unchanged. The MCP and site UI are separate following layers.
Closes #3. Closes #4.
Validation: 18 behavioral tests (including 384 bilingual recipe combinations), generated parity for 29 scripts, full
npm run verify, and Pages staging (7 HTML, 331 PNG/WebP pairs, zero forbidden files). Independent review reproduced an accessor boundary defect; regression tests were observed failing, the defect was fixed, and re-review passed.Depends on #10. Base:
codex/design-foundations; integration root:dev. This ordinary manual dependency PR contains only the shared core/recipes layer. Generated browser JS is committed because Pages serves it directly. No merge/deployment is performed.