Conversation
Commit 0109359 moved the Style Finder from an inline section into a <dialog> behind a new trigger button, but touched no CSS. finder.css kept styling the removed .style-finder shell while .finder-trigger and every .finder-dialog* class had no rules at all, so Chrome rendered a raw native button in the filter row and an unstyled native dialog. Add the missing rules: - .finder-trigger takes the control geometry of its .filter-btn and .search-input siblings, with the signal accent marking it as the one control that opens a tool rather than filtering the grid. - .finder-dialog becomes a centred card with a blurred ink ::backdrop, a ruled header and a circular close button, matching .modal-container, .modal-overlay and .modal-close on the same page. - Drop the dead .style-finder / .style-finder-header rules. - .finder-options now sizes to its container via auto-fit minmax rather than viewport breakpoints, since the finder lives in a fixed-width dialog, and .finder-option stacks the hint under the label so Korean option names no longer break mid-word. - Add a mobile bottom-sheet block and extend the reduced-motion, print and forced-colors blocks to the new controls. Colour follows the token contract in theme-atlas.css: --atlas-signal-text for anything read as text (trigger hover fills #B82E06 at 6.12:1 rather than #FF4D1F at 3.32:1) and --atlas-muted for the kicker and close glyph, since --atlas-ink-muted is not defined anywhere in the repo and silently resolved to a #7a7a7a fallback below AA. Verified with npm run verify and live browser QA at 1440x900 and 500x757, covering keyboard open/close, the full three-answer flow and the ranked results.
docs: credit design sources and plan recipe/MCP delivery
feat: add shared catalog queries and screen recipe contracts
feat: expose composable design queries through MCP and NDJSON
feat: add recipe-led atlas workflow and repair Finder focus
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the reviewed design recipe and Code Mode series from
devto GitHub Pages. The site gains three composable recipes, bilingual implementation briefs, and accessible Finder-to-detail navigation. The repository gains a compact read-only MCP and NDJSON interface, with pinned source and license notices.Frozen head:
e0fff467d0ea3f12e7fd5ab125fd967930dc63f0. Its tree matches reviewed UI head4229630fa4a8756edd148e48f0a68a5fa6bfd011. Includes #10, #11, #12, #13.Validation: dev push run 35723982589 passed full verification and Pages staging; 153 tests and browser QA across five widths are recorded in
devlog/_fin/260922_design_recipe_mcp/032_phase3_verification.md. Release gates require current PR CI, independent release audit, the main push Pages deployment, and live desktop/mobile smoke checks.Deployment uses the existing
.pages/allowlist andgithub-pagesenvironment. No workflow or dependency changes. Rollback restores the pre-release tree28d66113e9ab303b898585565e759b0ac2442088by reverting this merge with first parent preserved and running the same deployment workflow. The previous production revision and its workflow evidence are retained; rollback execution is only needed if production verification fails.Production proof: merged as
57e8fcab57df9d3cb8f1a2f94f2e4c28da7b32ac; Pages run 35724780873 passed all 153 tests, generated JS parity, staging and deployment. Artifact digest:sha256:c0bf0ecd914ee2cf3db464c1308ccf4949ae4a4837b653c7aa5576025c93a679. Live manifest and 88 public text files match the verified stage. Live Chromium smoke passed 1440/390/320px recipe selection, bilingual state, Finder and modal focus; all seven pages loaded with no console errors, failed responses or horizontal overflow.