ci: dual-lane simple-math smoke (no-think + thinking) — from #67 - #73
Open
antmikinka wants to merge 4 commits into
Open
ci: dual-lane simple-math smoke (no-think + thinking) — from #67#73antmikinka wants to merge 4 commits into
antmikinka wants to merge 4 commits into
Conversation
Mainline vehicle for stacked #67 dual-lane CI after #70/#71/#72 landed. - Matrix: no-think + thinking on ubuntu-rocm/cpu and macos-arm64 - Floor probe matches #71 nullopt-only (omit max_tokens; expect -1 → 4096) - CPU/mac thinking budgets 512 (ROCm stays 4096) to reduce OOM/timeout class fails - enable_thinking:false on other smoke curls; mode-scoped bench artifacts - Does not change thinking_budget.h / server floor policy
Quality review: ChatCompletionRequest::max_tokens is int default 4096, so omitting the field never yields GenerateParameters nullopt and never emits thinking_budget_floor -1→4096. #71 floor remains covered by tests/test_thinking_budget.cpp. Dual-lane inference smoke unchanged.
ubuntu-cpu-thinking failed: 512 tokens @ ~1.2 tok/s took ~421s wall, exceeding curl --max-time 300 (empty client response). Keep infer max_tokens at 512 on CPU and macOS; only raise infer_curl_max_time to 600.
Keep short job/matrix notes only; drop narrative about floor policy and PR history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Mainline vehicle for stacked #67 dual-lane CI after product stacks landed:
There was no prior
merge/pr67-into-main. Stacked #67 still targets obsoletesplit/pr63-03-load-hygiene.What
CI-only (3 files):
build-mlx-engine.ymlno-think+thinking× ubuntu-rocm / ubuntu-cpu / macos-arm64max_tokens=4096; CPU/mac thinking512(prior OOM/timeout class)enable_thinking: falsein action.yml + test-mlx-engine.ymlbench-results-${{ matrix.os }}-${{ matrix.mode }}Explicitly NOT in this PR
thinking_budget.h/ server floor policy changesmax_tokenscannot hit nullopt —ChatCompletionRequest::max_tokensdefaults to 4096). Floor covered bytests/test_thinking_budget.cppSupersedes
Stacked #67 (
split/pr63-04-ci-dual-smoke→split/pr63-03-load-hygiene). Close #67 in favor of this PR when green.Merge policy