Skip to content

split(#63)/2: stop sequences, thinking floor, role:tool 400 - #65

Closed
antmikinka wants to merge 7 commits into
feat/openai-tools-serverfrom
split/pr63-02-server-stop-thinking
Closed

split(#63)/2: stop sequences, thinking floor, role:tool 400#65
antmikinka wants to merge 7 commits into
feat/openai-tools-serverfrom
split/pr63-02-server-stop-thinking

Conversation

@antmikinka

@antmikinka antmikinka commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Stack 2/5 from mega PR #63 (after #64 merged into feat/openai-tools-server).

  • OpenAI stop strings (block + stream) + unit tests
  • Thinking budget floor 4096 + defaults + unit tests
  • role:tool clear 400 for OWUI Memory/tools
  • server.cpp single ownership unit for this stack slice

Base

Now feat/openai-tools-server (includes stack 1 / #64).

Stack

# PR Status
1 #64 ChatSession / EOS / pure MERGED into tools
2 This PR open
3 #66 load hygiene open
4 #67 CI dual smoke open
5 #68 docs open

No MTP enable.

@antmikinka
antmikinka changed the base branch from split/pr63-01-chatsession-eos-pure to feat/openai-tools-server July 20, 2026 00:44
@antmikinka

Copy link
Copy Markdown
Contributor Author

Retargeted base to feat/openai-tools-server now that #64 is merged. Branch includes merge of tools tip + server protocol commits. No self-merge.

Stack 2 polish for #65. Behavior unchanged. No MTP.
antmikinka added a commit that referenced this pull request Jul 20, 2026
antmikinka added a commit that referenced this pull request Jul 20, 2026
antmikinka added a commit that referenced this pull request Jul 20, 2026
@antmikinka

Copy link
Copy Markdown
Contributor Author

Further comment-only cleanup on server.cpp (redundant stop/floor notes removed per explore QA list). Behavior unchanged. Cascaded to #66#68 tips.

Same fix as merge/pr65-into-main (#71): floor only when budget is
unset; explicit client max_tokens always wins (unblocks simple-math CI).
@antmikinka

Copy link
Copy Markdown
Contributor Author

Same product belongs on main

Opened main retarget: #71

This stack PR still targets feat/openai-tools-server. Prefer landing #71 on main (human merge) once green.

CI fix pushed here too

thinking_budget_floor no longer rewrites explicit max_tokens (was 5→4096 → OOM kill on cpu/mac simple-math). Floor only applies when budget is unset.

@antmikinka

Copy link
Copy Markdown
Contributor Author

Closing in favor of main retarget

This stacked PR (base: feat/openai-tools-server) is superseded for mainline by:

#71

Why close #65

What was here

Area Status on #71
stop sequences + tests yes
thinking budget floor (explicit wins) yes
role:tool 400 yes
ChatSession / EOS not this PR — see #70
dual-lane CI still stack #67 (retarget main separately if needed)

Stack note

Original stack after #64 on tools. Prefer human merge of #71 → main when green. Do not re-open this PR for mainline work; open new main retargets for later slices (#66 load hygiene, #67 dual-lane) if those should also go main.

Closing as superseded by #71.

@antmikinka

Copy link
Copy Markdown
Contributor Author

Superseded by #71 (main retarget of this product slice). See closing comment for detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant