Skip to content

chore(deps): align workspace typescript devDependencies to ~6.0.3 - #113

Merged
kurone-kito merged 1 commit into
mainfrom
issue/110-align-workspace-typescript
Aug 10, 2026
Merged

chore(deps): align workspace typescript devDependencies to ~6.0.3#113
kurone-kito merged 1 commit into
mainfrom
issue/110-align-workspace-typescript

Conversation

@kurone-kito

@kurone-kito kurone-kito commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bump devDependencies.typescript from ~5.9.3 to ~6.0.3 in all
    five workspace packages (example-cli, example-lib, sea-builder,
    typescript-config, vite-lib-config) to match the root
    package.json, which already pinned ~6.0.3
  • Refresh pnpm-lock.yaml
  • Leave typescript-config's peerDependencies.typescript
    (>=5.7.x) untouched — narrowing it is issue Refine typescript-config's tsconfig.json for TypeScript v7 readiness #111's concern, once
    this floor is in place

Background

typedoc@0.28.20 (pulled in via vite-lib-config) declares a
typescript peer of 6.0.3, but the workspace resolved
typescript@5.9.3 for it — npm ls typescript --all reported it
invalid. Verified before/after: npm ls typescript --all had 20
invalid entries on main, including the typedoc one; after this
change it's down to 17, and none reference typedoc anymore. The
remaining invalid entries are pre-existing, unrelated third-party
peer-range mismatches (e.g. cosmiconfig-typescript-loader,
@microsoft/api-extractor both declaring ^5.2.2) outside this
issue's scope.

pnpm run build, pnpm run lint, and pnpm run test all pass under
TypeScript 6.0.3 — none of this repository's tsconfig.json files use
a setting TypeScript 6.0 deprecated.

Closes #110

Summary by CodeRabbit

  • Chores
    • Updated the TypeScript development tooling to version 6.0.3 across the project’s example applications, libraries, and build configuration packages.
    • No user-facing functionality or public APIs were changed.

The root package.json already pinned typescript@~6.0.3, but all five
workspace packages stayed on ~5.9.3, leaving typedoc's declared
typescript@6.0.3 peer unsatisfied workspace-wide (npm ls reported it
invalid). Bump each workspace package's devDependencies.typescript to
~6.0.3 to match the root and refresh the lockfile; leave
typescript-config's >=5.7.x peerDependencies range untouched, since
narrowing it is issue #111's concern once this floor is in place.

Refs #110
Copilot AI lite review requested due to automatic review settings August 10, 2026 08:26
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a882277a-f18e-467c-adf8-d52c3e431341

📥 Commits

Reviewing files that changed from the base of the PR and between 32da171 and 45c31c6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/example-cli/package.json
  • packages/example-lib/package.json
  • packages/sea-builder/package.json
  • packages/typescript-config/package.json
  • packages/vite-lib-config/package.json

📝 Walkthrough

Walkthrough

Five workspace package manifests update their TypeScript development dependency from ~5.9.3 to ~6.0.3. No exported or public entity declarations change.

Changes

Workspace TypeScript alignment

Layer / File(s) Summary
Update workspace TypeScript requirements
packages/example-cli/package.json, packages/example-lib/package.json, packages/sea-builder/package.json, packages/typescript-config/package.json, packages/vite-lib-config/package.json
The five package manifests now require TypeScript ~6.0.3 as a development dependency.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The package updates satisfy the issue, but the required lockfile refresh cannot be verified because pnpm-lock.yaml was excluded by path filters. Include pnpm-lock.yaml in the review or provide verifiable evidence that the lockfile was refreshed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency alignment and the target TypeScript version.
Description check ✅ Passed The description includes a summary, background, affected packages, validation results, and scope boundaries.
Out of Scope Changes check ✅ Passed The changes are limited to the requested TypeScript devDependency alignment across the five workspace packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/110-align-workspace-typescript

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns all workspace package TypeScript devDependencies to the root-pinned ~6.0.3, primarily to eliminate the typedoc@0.28.20 peer mismatch caused by workspace resolution previously landing on ~5.9.3. This is a maintenance/dependency hygiene change across the monorepo’s build/tooling packages and examples.

Changes:

  • Bumped devDependencies.typescript from ~5.9.3 to ~6.0.3 in all five workspace packages.
  • Refreshed pnpm-lock.yaml to reflect the new resolution (including typedoc now resolved with typescript@6.0.3).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Lockfile refresh reflecting TypeScript 6.0.3 in workspace importers and typedoc resolution.
packages/example-cli/package.json Updates workspace package TypeScript devDependency to ~6.0.3.
packages/example-lib/package.json Updates workspace package TypeScript devDependency to ~6.0.3.
packages/sea-builder/package.json Updates workspace package TypeScript devDependency to ~6.0.3.
packages/typescript-config/package.json Updates TypeScript devDependency to ~6.0.3 while leaving the peer range unchanged.
packages/vite-lib-config/package.json Updates TypeScript devDependency to ~6.0.3 (relevant to typedoc peer alignment).
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kurone-kito

This comment has been minimized.

@kurone-kito
kurone-kito merged commit 9e77cc2 into main Aug 10, 2026
26 of 27 checks passed
@kurone-kito
kurone-kito deleted the issue/110-align-workspace-typescript branch August 10, 2026 08:56
@github-actions

Copy link
Copy Markdown

F4 Cleanup Evidence (server-side fallback via post-merge-cleanup.yml)

Field Value
Status applied
Applied 1
Failed 0
Skipped 2
Permission-blocked 0
Posted by post-merge-cleanup workflow

kurone-kito added a commit that referenced this pull request Sep 5, 2026
address review feedback on this pr:

- typescript-config's #111 entry claimed strict and esModuleInterop
  both became mandatory, non-overridable typescript 6.0+ defaults.
  verified empirically (installed typescript 7.0.2, an isolated
  scratch tsconfig): explicitly setting esModuleInterop=false is
  rejected with a hard compiler error (ts5108, "has been removed"),
  but strict=false is accepted without error. reworded to state each
  option's actual behavior separately, and to name ~7.0.2 as the
  final shipped typescript floor (superseding the earlier ~6.0.3
  entry from #113).
- vite-lib-config's routine-refresh (#207) bullet listed vite's
  further bump to ^8.2.2 without noting it supersedes the ^8.0.0
  entry from #121; added that cross-reference and named ^8.2.2 as the
  final shipped range.
- sea-builder's routine-refresh (#207) bullet described execa,
  listr2, and semver as devdependencies; they are runtime
  dependencies in this package's package.json. split the bullet into
  dependencies and devdependencies groups.
- typescript-config was missing an entry for #192, which added a
  readme note (with a link) that this package migrated from
  lints-config -- confirmed via the pr's own file list and re-swept
  every package's readme.md history since v0.21.0 for any other gaps
  (none found).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hd2P6cGiAJh89QgukAyGef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align workspace typescript devDependencies to ~6.0.3

2 participants