chore(deps): align workspace typescript devDependencies to ~6.0.3 - #113
Conversation
The root package.json already pinned typescript@~6.0.3, but all five workspace packages stayed on ~5.9.3, leaving typedoc's declared typescript@6.0.3 peer unsatisfied workspace-wide (npm ls reported it invalid). Bump each workspace package's devDependencies.typescript to ~6.0.3 to match the root and refresh the lockfile; leave typescript-config's >=5.7.x peerDependencies range untouched, since narrowing it is issue #111's concern once this floor is in place. Refs #110
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughFive workspace package manifests update their TypeScript development dependency from ChangesWorkspace TypeScript alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Aligns all workspace package TypeScript devDependencies to the root-pinned ~6.0.3, primarily to eliminate the typedoc@0.28.20 peer mismatch caused by workspace resolution previously landing on ~5.9.3. This is a maintenance/dependency hygiene change across the monorepo’s build/tooling packages and examples.
Changes:
- Bumped
devDependencies.typescriptfrom~5.9.3to~6.0.3in all five workspace packages. - Refreshed
pnpm-lock.yamlto reflect the new resolution (includingtypedocnow resolved withtypescript@6.0.3).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh reflecting TypeScript 6.0.3 in workspace importers and typedoc resolution. |
| packages/example-cli/package.json | Updates workspace package TypeScript devDependency to ~6.0.3. |
| packages/example-lib/package.json | Updates workspace package TypeScript devDependency to ~6.0.3. |
| packages/sea-builder/package.json | Updates workspace package TypeScript devDependency to ~6.0.3. |
| packages/typescript-config/package.json | Updates TypeScript devDependency to ~6.0.3 while leaving the peer range unchanged. |
| packages/vite-lib-config/package.json | Updates TypeScript devDependency to ~6.0.3 (relevant to typedoc peer alignment). |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
|
F4 Cleanup Evidence (server-side fallback via
|
address review feedback on this pr: - typescript-config's #111 entry claimed strict and esModuleInterop both became mandatory, non-overridable typescript 6.0+ defaults. verified empirically (installed typescript 7.0.2, an isolated scratch tsconfig): explicitly setting esModuleInterop=false is rejected with a hard compiler error (ts5108, "has been removed"), but strict=false is accepted without error. reworded to state each option's actual behavior separately, and to name ~7.0.2 as the final shipped typescript floor (superseding the earlier ~6.0.3 entry from #113). - vite-lib-config's routine-refresh (#207) bullet listed vite's further bump to ^8.2.2 without noting it supersedes the ^8.0.0 entry from #121; added that cross-reference and named ^8.2.2 as the final shipped range. - sea-builder's routine-refresh (#207) bullet described execa, listr2, and semver as devdependencies; they are runtime dependencies in this package's package.json. split the bullet into dependencies and devdependencies groups. - typescript-config was missing an entry for #192, which added a readme note (with a link) that this package migrated from lints-config -- confirmed via the pr's own file list and re-swept every package's readme.md history since v0.21.0 for any other gaps (none found). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hd2P6cGiAJh89QgukAyGef
Summary
devDependencies.typescriptfrom~5.9.3to~6.0.3in allfive workspace packages (
example-cli,example-lib,sea-builder,typescript-config,vite-lib-config) to match the rootpackage.json, which already pinned~6.0.3pnpm-lock.yamltypescript-config'speerDependencies.typescript(
>=5.7.x) untouched — narrowing it is issue Refine typescript-config's tsconfig.json for TypeScript v7 readiness #111's concern, oncethis floor is in place
Background
typedoc@0.28.20(pulled in viavite-lib-config) declares atypescriptpeer of6.0.3, but the workspace resolvedtypescript@5.9.3for it —npm ls typescript --allreported itinvalid. Verified before/after:npm ls typescript --allhad 20invalid entries on
main, including thetypedocone; after thischange it's down to 17, and none reference
typedocanymore. Theremaining invalid entries are pre-existing, unrelated third-party
peer-range mismatches (e.g.
cosmiconfig-typescript-loader,@microsoft/api-extractorboth declaring^5.2.2) outside thisissue's scope.
pnpm run build,pnpm run lint, andpnpm run testall pass underTypeScript 6.0.3 — none of this repository's
tsconfig.jsonfiles usea setting TypeScript 6.0 deprecated.
Closes #110
Summary by CodeRabbit