docs(changelog): backfill in-repo release history across all 3 packages - #114
Conversation
sea-builder, typescript-config, and vite-lib-config all shipped CHANGELOG.md scaffolding with an empty Unreleased heading in #106, but none of their release history was populated yet. Classify every merged PR through #113 by Conventional Commits scope, falling back to changed-file paths under each package's directory, and add Keep a Changelog entries to whichever of the three packages each PR actually touched, under Unreleased / 0.21.0 / 0.20.0 as applicable. typescript-config's 0.20.0 section only records the lints-config migration note per #106's policy, since its own pre-migration history is issue #108's concern. Refs #107
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Copilot and Chatgpt-codex flagged three findings on PR #114: (1) typescript-config's migration note referenced content further down the file that does not exist yet, until #108 backfills it -- point at that tracking issue instead; (2) sea-builder was missing a 0.21.0 section even though PR #19 bumped its listr2 dependency and version, verified against the actual file diff; (3) #45's changelog entry duplicated #44's undici bump -- #45's merge commit has an empty diff against its first parent, confirmed with git diff, since the same change had already landed by the time it merged. Refs #107
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
packages/typescript-config/CHANGELOG.md:34
- The PR references at the end of this entry are a bit hard to parse as
(#108) (#2). Consider consolidating into a single parenthetical so it’s clear which PR is the initial migration vs the follow-up backfill.
- Migrated from `kurone-kito/lints-config`; its pre-migration history
will be backfilled in a follow-up (#108) (#2).
|
Accepted — Copilot's suppressed comment on |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Chatgpt-codex flagged the 0.21.0 entry on PR #114: "Improved the TypeScript configuration" hid that #19 added erasableSyntaxOnly: true, verified against the actual tsconfig.json diff, a breaking change for any 0.20 consumer using syntax that needs emit-time transformation. Name the option and mark it breaking. Refs #107
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Chatgpt-codex flagged the shared Breaking entry on PR #114: it only described dropping Node.js 20, hiding that #88 also raised the floor within Node.js 22/24 and dropped Node.js 25 entirely, verified against the actual engines.node diff in all three package.json files. State the exact before/after ranges in each of the three CHANGELOGs. Refs #107
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Chatgpt-codex flagged that the 0.21.0 section on PR #114 only recorded the TypeDoc pipeline, omitting that #19 also bumped the runtime type-fest and vite dependencies, verified against the actual package.json diff. type-fest jumped a major version and is used by the exported ViteConfigOptions type. Refs #107
Proactively audited every entry-bearing PR (#19, #41, #42, #44, #66, #70-#76, #88) against actual package.json diffs, applying the same "runtime dep / breaking config / vague wording" lens Codex used across five prior review rounds, instead of waiting for another round-trip. Found: #19 also bumped cpy-cli and typescript devDependencies in all three target packages (plus type-fest and undici for sea-builder), none previously recorded under 0.21.0. Also replaced the vague "grouped Dependabot update (#44)" wording in sea-builder and vite-lib-config with the actual packages/versions it bumped, matching this backfill's established granularity for every other dependency bump entry. Refs #107
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Self-initiated audit — After five rounds of Codex findings all sharing one shape (runtime dep bumps / breaking config changes / vague wording missed by title-derived entries), I re-applied that same lens myself across every entry-bearing PR in this backfill's range (#19, #41, #42, #44, #66, #70-#76, #88) instead of waiting for another round-trip. Verified against
No other gaps found (#41/#42/#66/#75/#76 already correctly documented; #88's target-package changes are fully covered by the existing engines.node and Vite build-target entries). Fixed in 493b7ce (round-6 finding) and a7603b6 (this audit). |
This comment has been minimized.
This comment has been minimized.
Chatgpt-codex flagged three more gaps in the reviewed release notes, each verified against the actual PR diff before accepting: - typescript-config's peerDependencies still advertises `>=5.7.x`, but erasableSyntaxOnly (enabled in #19) requires TypeScript 5.8+; noted the effective floor so consumers on 5.7 know to upgrade. - #88 also fixed vite-lib-config's TypeDoc build (resolving typedoc-plugin-markdown under pnpm's virtual store) and added working external link mappings for Vite symbols in the generated docs, previously undocumented. - #70's JSDoc fix entry only mentioned the shebang/library-mode branch inversion; broadened it to cover the filtered-entries and mixed-entries behavior it also documented, and vitestConfig's wholesale rewrite from a copy-pasted, incorrect description to its actual test.environment merge behavior. Refs #107
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (2)
packages/sea-builder/CHANGELOG.md:14
- The changelog correctly attributes the initial
CHANGELOG.mdscaffolding to PR #112, but this PR’s description says the files were "scaffolded empty in #106" (which appears to be the issue number closed by #112). Please align the PR description wording so it references PR #112 (or clarify that #106 is an issue, not a PR) to avoid confusion when tracing history.
- `CHANGELOG.md` (#112).
packages/sea-builder/CHANGELOG.md:22
- Version formatting is inconsistent in this section: other entries wrap exact versions in backticks (e.g.
7.24.0), but this line uses a literal "v7.28.0" without backticks. For consistency (and to keep Markdownlint-friendly formatting), format it like the other version literals.
- Bumped the `undici` devDependency to v7.28.0 (#66).
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Rejected — coderabbitai[bot] did not review HEAD 8be2cd2 (review limit reached / rate limited); this is not a completed review (source: #issuecomment-5238092912) |
This comment has been minimized.
This comment has been minimized.
|
F4 Cleanup Evidence (server-side fallback via
|
Summary
Backfill
sea-builder,typescript-config, andvite-lib-config'sCHANGELOG.md(scaffolded empty in #106) with every merged PR through#113, classified deterministically:
packages/<target-package>/.example-cli/example-lib/nopackages/pathgets no entry (listed below).
entry in each.
The target range grew from the issue's original
#2–#104to include#112/#113, both merged after this issue was authored — re-verifiedper the issue's own instruction before starting.
typescript-config's## [0.20.0]section only records thelints-configmigration note, per #106's policy; its detailedpre-migration history is issue #108's concern.
Excluded
undicibump had already landed via chore(deps-dev): bump the npm_and_yarn group across 4 directories with 2 updates #44's grouped update by thetime chore(deps-dev): bump undici from 7.16.0 to 7.24.0 in /packages/sea-builder in the npm_and_yarn group across 1 directory #45 merged)
chore(deps-dev), only@kurone-kito/markdownlint-configbumpchore(deps-dev), onlymarkdownlint-cli2bumpchore(deps), onlyactions/checkoutfix(root), only.coderabbit.yamlfix(ci), only the npmjs publish workflowfix(ci), only Action SHA pinningchore(deps), onlyrelease-drafter/release-drafterchore(deps), onlyactions/setup-nodechore(deps), onlysoftprops/action-gh-releasechore(deps), onlypnpm/action-setupchore(deps), onlyactions/stalefix(root), only rootvitest/lockfilefeat(root), IDD workflow template importfeat(root), IDD enforcement gateschore(root),idd-skillpin bumpdocs(root), IDD instruction reconciliationfeat(root), advisory-bot/CI-gate policy schemaci(root),idd-advisory-convergenceredesignfeat(root), strip untrusted IDD labelschore(root), drop the stale babel overrideAcceptance criteria
CHANGELOG.mdhas version headings only where ithas entries for that release
typescript-config's## [0.20.0]includes the migration notepnpm run lintpassesCloses #107
Summary by CodeRabbit