Skip to content

Refactor the test cases for sinkbindingselectionmode#2113

Closed
houshengbo wants to merge 2 commits into
knative:mainfrom
houshengbo:improve-tests
Closed

Refactor the test cases for sinkbindingselectionmode#2113
houshengbo wants to merge 2 commits into
knative:mainfrom
houshengbo:improve-tests

Sync vendor directory with go.mod and go.sum

fb4daec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 11, 2025 in 0s

61.94% (target 80.00%)

View this Pull Request on Codecov

61.94% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 55.14019% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.94%. Comparing base (923f031) to head (fb4daec).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/common/base_reconciler.go 0.00% 28 Missing ⚠️
pkg/reconciler/common/workload_override.go 70.58% 14 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   62.16%   61.94%   -0.22%     
==========================================
  Files          49       50       +1     
  Lines        2318     2381      +63     
==========================================
+ Hits         1441     1475      +34     
- Misses        785      815      +30     
+ Partials       92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.