Skip to content

Refactor the test cases for sinkbindingselectionmode#2113

Closed
houshengbo wants to merge 2 commits into
knative:mainfrom
houshengbo:improve-tests
Closed

Refactor the test cases for sinkbindingselectionmode#2113
houshengbo wants to merge 2 commits into
knative:mainfrom
houshengbo:improve-tests

Conversation

@houshengbo

Copy link
Copy Markdown
Contributor

No description provided.

@knative-prow knative-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 11, 2025
@knative-prow

knative-prow Bot commented Jul 11, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@knative-prow knative-prow Bot requested review from aliok and matzew July 11, 2025 21:24
@knative-prow knative-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 12, 2025
@knative-prow knative-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2025
@codecov

codecov Bot commented Jul 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.14019% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.94%. Comparing base (923f031) to head (fb4daec).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/common/base_reconciler.go 0.00% 28 Missing ⚠️
pkg/reconciler/common/workload_override.go 70.58% 14 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   62.16%   61.94%   -0.22%     
==========================================
  Files          49       50       +1     
  Lines        2318     2381      +63     
==========================================
+ Hits         1441     1475      +34     
- Misses        785      815      +30     
+ Partials       92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2025
@knative-prow-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso

Copy link
Copy Markdown
Member

bump @houshengbo unsure if you still need this

@houshengbo houshengbo closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants