Skip to content

Mask negative bits to prevent negative projectIds in BuildForm.java and ProjectForm.java - #157

Merged
basil merged 1 commit into
jenkinsci:masterfrom
shlomomdahan:fix-negative-projectIds
Nov 8, 2024
Merged

Mask negative bits to prevent negative projectIds in BuildForm.java and ProjectForm.java#157
basil merged 1 commit into
jenkinsci:masterfrom
shlomomdahan:fix-negative-projectIds

Conversation

@shlomomdahan

Copy link
Copy Markdown
Contributor

IDs were sometimes being returned as negative ints which break pipeline functionality.

ref:

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan
shlomomdahan requested a review from a team as a code owner November 8, 2024 20:35
shlomomdahan added a commit to shlomomdahan/build-pipeline-plugin that referenced this pull request Nov 8, 2024

@basil basil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil
basil merged commit 7da034a into jenkinsci:master Nov 8, 2024
@shlomomdahan
shlomomdahan deleted the fix-negative-projectIds branch November 8, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants